test: add a JS unit test to verify filterSubVerticals #4561
Conversation
Ali-D-Akbar
force-pushed
the
aakbar/PROD-4296
branch
3 times, most recently
from
87dd832 to
e4f966c
Compare
Ali-D-Akbar
force-pushed
the
aakbar/PROD-4296
branch
5 times, most recently
from
71d27e9 to
0249489
Compare
| def test_filter_sub_verticals_javascript(self): | ||
| """ | ||
| Verify that selecting a vertical with one sub-vertical (AI and Business) shows the expected single sub-vertical | ||
| and a vertical with two sub-verticals ('Data') shows both sub-verticals. |
There was a problem hiding this comment.
not sure if we need to add vertical and subvertical name in docstring
| self.vertical = VerticalFactory(name='AI') | ||
| self.sub_vertical = SubVerticalFactory(name='Machine Learning', vertical=self.vertical) | ||
|
|
||
| self.other_vertical = VerticalFactory(name='Business') |
There was a problem hiding this comment.
we can use some dummy test verticals instead of adding actual verticals here
| ) | ||
| return self.get_visible_options('sub_vertical') | ||
|
|
||
| def test_filter_sub_verticals_javascript(self): |
There was a problem hiding this comment.
btw this testcase is failing
Ali-D-Akbar
force-pushed
the
aakbar/PROD-4296
branch
2 times, most recently
from
a3d2d8b to
5a11233
Compare
| super().setUp() | ||
| ContentType.objects.clear_cache() | ||
|
|
||
| self.user = UserFactory(username='superuser_func', is_superuser=True, is_staff=True) |
There was a problem hiding this comment.
Is superuser a better username?
| self.driver.get(self.url) | ||
|
|
||
| def _login(self): | ||
| """Log into Django via test client, then add the session cookie to Selenium.""" |
There was a problem hiding this comment.
Would it be better to log in naturally? i.e through the browser?
There was a problem hiding this comment.
ProgramAdminFunctionalTests does it like that.
There was a problem hiding this comment.
That's what I did earlier ;-;
| super().setUpClass() | ||
| firefox_options = Options() | ||
| firefox_options.headless = True | ||
| cls.driver = webdriver.Firefox(options=firefox_options) |
There was a problem hiding this comment.
Isn't it the same?
| "document.getElementById('vertical').dispatchEvent(new Event('change'));" | ||
| ) | ||
| # Wait until the visible sub-vertical options match the expected set. | ||
| WebDriverWait(self.driver, 5).until( |
There was a problem hiding this comment.
We have an implicit_wait in the init too. Are both these waits needed?
There was a problem hiding this comment.
Both waits are not particularly “redundant” because implicitly_wait applies whenever we have a find_element() but this explicit wait is to apply the change event on the element.
| self.assertEqual(len(visible_options), 2) | ||
| self.assertEqual(option_values, expected_values) | ||
|
|
||
|
|
There was a problem hiding this comment.
We should have a test for the initial load too i.e before the user has interacted with the page. I recall that being a discussed during develppment
Ali-D-Akbar
force-pushed
the
aakbar/PROD-4296
branch
from
5a11233 to
27ad269
Compare
PROD-4296
Adds selenium-based unit tests to verify JS script added to load subverticals on the course tagging detail page.