Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Create script to autmate project creation fix: #2026 #2036

Closed
wants to merge 1 commit into from

Conversation

ghassanmas
Copy link
Member

@ghassanmas ghassanmas commented Mar 8, 2022

This script is expected to run either by dispatch or when a
new open-release occur which it's name ends with '.1' It
expects a TX_TOKEN to be exist when the script is triggered.
This script is wont recreate a project if runs twice for same
name release.

The API calls is based on transifex API V3, doc can found at:
https://developers.transifex.com/reference/api-introduction

This flow has been tested on my repo for repo that I used for openedx expirments, as well as with my transifex orgnization which I used for testing as well

TX org for testing: https://www.transifex.com/open-edx-docs
Github repo for testing: https://github.com/ghassanmas/openedx-docs and most importantly look at the previous actions https://github.com/ghassanmas/openedx-docs/actions

Configuration that might to changed or be dynamic (some already are):

Config Name current implmentation
machine_translation_fillup False
translation_memory_fillup True
private False
repository_url https://github.com/openedx/edx-documentation
source_language en_us
slug The proejct slug is dynmically created refer this convert_release_to_project_slug for more details.

Also more configuration that aren't required can be added, please refer to doc about creating new porject at for mroe info.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Mar 8, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @ghassanmas! I've created OSPR-6510 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ghassanmas
Copy link
Member Author

This ready for review

@natabene
Copy link

natabene commented Mar 8, 2022

@ghassanmas Thank you, I will line this up.

  This script is expected to run either by dispatch or when a
  new open-release occur which it's name ends with '.1' It
  expects a TX_TOKEN to be exist when the script is triggered.
  This script is wont recreate a project if runs twice for same
  name release.
  The API calls is based on transifex API V3, doc can found at:
  https://developers.transifex.com/reference/api-introduction
@ghassanmas
Copy link
Member Author

Also closes part of #2018

Copy link
Contributor

@Carlos-Muniz Carlos-Muniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghassanmas Thank you for your work here, but we are not quite at the stage to accept this PR. As stated over slack:

There is far more needed than just a PR to make a github action, though its in the right direction. Since there will be lots of moving parts, there should be coordination between them. We think that making a PR for the github action before we have everything in order may be acting too hastily. Especially since it may cause the folks in the Transifex WG to have to keep redoing work as we figure out a system that will work for everyone. It's better to provide some alleviation for now in the way of a script, work on a plan, create designs, talk them over with those effected, and then implement it.

We will be closing this PR, though we may reopen it at a later time, if appropriate.

@openedx-webhooks
Copy link

@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants