fix: compare emails case-insensitively when setting assignment lms_user_ids #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macdiesel
approved these changes
Dec 12, 2023
johnnagro
approved these changes
Dec 12, 2023
pwnage101
previously requested changes
Dec 12, 2023
| # OR type of query. | ||
| email_filter = Q() | ||
| for assignment_email in emails: | ||
| email_filter |= Q(email__iexact=assignment_email) |
There was a problem hiding this comment.
FWIW, I think this would increase the statement length (adding a string of OR email checks instead of a flat list of emails). Might be worth halving USER_EMAIL_READ_BATCH_SIZE to 175 just to be safe.
There was a problem hiding this comment.
Tuned it down to a nice even 100.
…er_ids ENT-8129 | The email stored on assignment records might be only a case-insensitive match to the corresponding email in the core.User records, so do case-insensitive matching during the assignment flow and during the post-user-save signal that updates assignment ``lms_user_ids``.
iloveagent57
force-pushed
the
aed/like-being-low
branch
from
7abaac3 to
17c3d27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENT-8129 | The email stored on assignment records might be only a case-insensitive match to the corresponding email in the core.User records, so do case-insensitive matching during the assignment flow and during the post-user-save signal that updates assignment
lms_user_ids.