Skip to content

Conversation

@zwidekalanga
Copy link
Contributor

@zwidekalanga zwidekalanga commented Jul 22, 2025

  • Remove getLastActionStatus function, use API values directly
  • Fix errorReason field access after camelCase transformation
  • Add nested field filtering/sorting (action_status, action_error_reason)
  • Implement configuration-driven filtering for maintainability
  • Update status mappings (reminded vs waiting_for_learner)
  • Fix BnrRequestStatusCell error display (failed_approval → "Failed: Approval")
  • Add React.memo optimizations and fix deprecation warnings
  • Update tests for new API structure

Maintains backward compatibility while enabling enhanced filtering capabilities.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

…ring

- Remove getLastActionStatus function, use API values directly
- Fix errorReason field access after camelCase transformation
- Add nested field filtering/sorting (action_status, action_error_reason)
- Implement configuration-driven filtering for maintainability
- Update status mappings (reminded vs waiting_for_learner)
- Fix BnrRequestStatusCell error display (failed_approval → "Failed: Approval")
- Add React.memo optimizations and fix deprecation warnings
- Update tests for new API structure

Maintains backward compatibility while enabling enhanced filtering capabilities.
@zwidekalanga zwidekalanga force-pushed the feat/learner-credit-request-supporting-filtering branch from c26c034 to 5c99423 Compare July 22, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant