Analytics V2 Release #1709
Open
Analytics V2 Release #1709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammad-ammar
force-pushed
the
ammar/analytics-v2-product-tour-flow
branch
2 times, most recently
from
f8511e0 to
b0a4e67
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1709 +/- ##
==========================================
+ Coverage 87.11% 87.13% +0.01%
==========================================
Files 780 781 +1
Lines 17767 17794 +27
Branches 3716 3640 -76
==========================================
+ Hits 15477 15504 +27
- Misses 2215 2226 +11
+ Partials 75 64 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
muhammad-ammar
force-pushed
the
ammar/analytics-v2-product-tour-flow
branch
2 times, most recently
from
f74d090 to
fc56c9b
Compare
mahamakifdar19
approved these changes
Oct 21, 2025
| )} | ||
|
|
||
| {enableAnalyticsPage && enterpriseAppPage === ROUTE_NAMES.analytics && ( | ||
| {enableAnalyticsPage && enterpriseAppPage === ROUTE_NAMES.analytics_v1 && features.ADMIN_V1 && ( |
There was a problem hiding this comment.
I think we no longer need the analytics-v1 route. It can be removed. The only required route now is analytics.
| }); | ||
|
|
||
| it('renders AnalyticsV2Page when ANALYTICS_SUPPORTED is true', () => { | ||
| it('renders AnalyticsV2Page when ANALYTICS_SUPPORTED and ADMIN_V1 is true', () => { |
There was a problem hiding this comment.
Similarly, this test will no longer be required once we remove the ADMIN_V1 feature flag check.
| export const ROUTE_NAMES = { | ||
| analytics: 'analytics', | ||
| analytics_v2: 'analytics-v2', | ||
| analytics_v1: 'analytics-v1', |
There was a problem hiding this comment.
This can be removed as well since we no loner need analytics-v1 route
feat: analytics v2 onboarding flow feat: analytics v2 new feature notification
muhammad-ammar
force-pushed
the
ammar/analytics-v2-product-tour-flow
branch
from
fc56c9b to
a59d4c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Enable analytics v2, add onboarding flow and new feature notification.
JIRA:
For all changes
Only if submitting a visual change