Fix infinite API call loop in AdminSearchForm #1717
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue:
After the recent merge of PR #1635 the LPR page became unresponsive on production due to an infinite API call loop. The root cause was that on
AdminSearchFormthesearchEnrollmentsListwas being called inside auseEffectwith the function itself in the dependency array. Since the function was recreated on every render, React treated it as a new dependency each time, causinguseEffectto run repeatedly and trigger endless API calls.Fix:
This PR fixes the infinite API call issue on the LPR page by passing the
searchEnrollmentsListfunction directly toAdminSearchForminstead of recreating it on each render. This prevents the function from triggering repeatedly and resolves the unresponsiveness observed in production.For all changes
Only if submitting a visual change