-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clicking on back button after post creation #745
base: master
Are you sure you want to change the base?
fix: clicking on back button after post creation #745
Conversation
Thanks for the pull request, @DmytroAlipov! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
=======================================
Coverage 93.17% 93.18%
=======================================
Files 161 161
Lines 3401 3402 +1
Branches 924 924
=======================================
+ Hits 3169 3170 +1
Misses 214 214
Partials 18 18 ☔ View full report in Codecov by Sentry. |
Hi @openedx/2u-infinity! This is ready for review. |
Friendly ping on this @openedx/2u-infinity |
589c862
to
a17949f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
A bug fix to ensure that the correct post ID is retained and processed when clicking the browser back button after creating a post. Key changes include:
- Adding a null check for post objects before processing in the post list hook.
- Updating the merging logic for post IDs in the discussions slice to avoid unpacking errors.
Reviewed Changes
File | Description |
---|---|
src/discussions/posts/data/hooks.js | Adds a check for post existence before processing. |
src/discussions/posts/data/slices.js | Updates array merging logic for post IDs. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
@@ -92,7 +92,7 @@ const threadsSlice = createSlice({ | |||
if (!updatedPages[page - 1]) { | |||
updatedPages[page - 1] = ids; | |||
} else { | |||
updatedPages[page - 1] = [...new Set([...updatedPages[page - 1], ...ids])]; | |||
updatedPages[page - 1] = [...new Set([updatedPages[page - 1], ...ids])]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updatedPages[page - 1] array is not being spread into the set, which may lead to nested arrays and incorrect deduplication. Consider reverting to spreading the array as in the original code: [...new Set([...updatedPages[page - 1], ...ids])].
updatedPages[page - 1] = [...new Set([updatedPages[page - 1], ...ids])]; | |
updatedPages[page - 1] = [...new Set([...updatedPages[page - 1], ...ids])]; |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Description
Steps to Reproduce:
Open course in LMS
Open discussions sidebar
Add post -> Submit

Click on back browser button

Result

Result of the investigation:
Found that

post id
is unpacked when saving to state, although it should be saved intact:After fixing the unpacking, this error also started to occur:

I have added a check that the post exists to fix this situation:
