-
Notifications
You must be signed in to change notification settings - Fork 19
Replace injectIntl with the useIntl() hook #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, @diana-villalvazo-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
5d5f391
to
1d5d50b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #574 +/- ##
==========================================
+ Coverage 85.87% 86.00% +0.12%
==========================================
Files 27 27
Lines 439 443 +4
Branches 102 102
==========================================
+ Hits 377 381 +4
Misses 61 61
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Will merge today
Description
As part of the project for improvements as follow up of react-unit-test-utils, we are going to replace all usages of the deprecated
injectIntl
HOC with theuseIntl()
hook from @edx/frontend-platform/i18n. It is a very straight-forward change, in order to accomplish this we did the following changes:injectIntl
, remove intl as a prop and use the hook instead.injectIntl
and just use the desired component wrapped in aIntlProvider
(from @edx/frontend-platform/i18n).Support Information
Closes #568