-
Notifications
You must be signed in to change notification settings - Fork 243
feat: improved accessibility skipping to main content #1599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: improved accessibility skipping to main content #1599
Conversation
Thanks for the pull request, @vladislavkeblysh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
8cab1e9
to
5420474
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1599 +/- ##
==========================================
+ Coverage 90.18% 90.24% +0.05%
==========================================
Files 339 339
Lines 5810 5742 -68
Branches 1409 1398 -11
==========================================
- Hits 5240 5182 -58
+ Misses 552 543 -9
+ Partials 18 17 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
38c66ab
to
99b5e8e
Compare
@vladislavkeblysh Thank you for this contribution! |
6719338
to
2f2b8bb
Compare
@vladislavkeblysh Since this PR seems to include user-facing changes, you'll likely need to get product approval for it. When you're ready please follow the instructions from the bot to get that process started. |
Hey @vladislavkeblysh, just checking in to see if you're still planning to continue working on this PR? |
7d04658
to
7aee577
Compare
7aee577
to
7493dfb
Compare
@itsjeyd Ready to review |
Jump user's focus skipping two navigation menus above it