Skip to content

feat: improved accessibility skipping to main content #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vladislavkeblysh
Copy link

Jump user's focus skipping two navigation menus above it

  • Progress page
  • Course unit
  • Dates page

363789603-42d7d1e1-f026-4596-a65d-8197aa4a366c

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 24, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 24, 2025

Thanks for the pull request, @vladislavkeblysh!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/accessibility-skipping-to-main-content branch from 8cab1e9 to 5420474 Compare February 24, 2025 14:17
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (af432ea) to head (7493dfb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1599      +/-   ##
==========================================
+ Coverage   90.18%   90.24%   +0.05%     
==========================================
  Files         339      339              
  Lines        5810     5742      -68     
  Branches     1409     1398      -11     
==========================================
- Hits         5240     5182      -58     
+ Misses        552      543       -9     
+ Partials       18       17       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/accessibility-skipping-to-main-content branch 2 times, most recently from 38c66ab to 99b5e8e Compare February 24, 2025 15:59
@vladislavkeblysh vladislavkeblysh marked this pull request as draft February 24, 2025 16:49
@vladislavkeblysh vladislavkeblysh self-assigned this Feb 24, 2025
@itsjeyd
Copy link

itsjeyd commented Feb 27, 2025

@vladislavkeblysh Thank you for this contribution!

@vladislavkeblysh vladislavkeblysh marked this pull request as ready for review March 12, 2025 13:20
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/accessibility-skipping-to-main-content branch 2 times, most recently from 6719338 to 2f2b8bb Compare March 12, 2025 15:29
@itsjeyd
Copy link

itsjeyd commented Mar 14, 2025

@vladislavkeblysh Since this PR seems to include user-facing changes, you'll likely need to get product approval for it. When you're ready please follow the instructions from the bot to get that process started.

@itsjeyd itsjeyd added the product review PR requires product review before merging label Mar 14, 2025
@itsjeyd
Copy link

itsjeyd commented Apr 10, 2025

Hey @vladislavkeblysh, just checking in to see if you're still planning to continue working on this PR?

@itsjeyd itsjeyd added the inactive PR author has been unresponsive for several months label Apr 10, 2025
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/accessibility-skipping-to-main-content branch 3 times, most recently from 7d04658 to 7aee577 Compare April 15, 2025 15:17
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/accessibility-skipping-to-main-content branch from 7aee577 to 7493dfb Compare April 15, 2025 15:23
@vladislavkeblysh
Copy link
Author

@itsjeyd Ready to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive PR author has been unresponsive for several months open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

3 participants