Skip to content

refactor: change to useIntl #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

KristinAoki
Copy link
Member

@KristinAoki KristinAoki commented Mar 11, 2025

Description

This PR replaces injectIntl and intlShape with useIntl. injectIntl and intlShape are both deprecated. It should be noted that this PR skips the refactor in the following places:

  • progress-tab folder
  • Section.jsx
  • SequenceLink.jsx

Each of these has an open PR that includes the refactor (#1619, #1632)

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 11, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @KristinAoki!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@KristinAoki
Copy link
Member Author

@openedx/committers-frontend-app-learning this PR is ready to be reviewed

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 95.80420% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.18%. Comparing base (af432ea) to head (391096b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../access-expiration-alert/AccessExpirationAlert.jsx 0.00% 2 Missing ⚠️
src/alerts/enrollment-alert/EnrollmentAlert.jsx 0.00% 2 Missing ⚠️
...rc/alerts/logistration-alert/LogistrationAlert.jsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1634      +/-   ##
==========================================
- Coverage   90.18%   90.18%   -0.01%     
==========================================
  Files         339      338       -1     
  Lines        5810     5726      -84     
  Branches     1409     1379      -30     
==========================================
- Hits         5240     5164      -76     
+ Misses        552      543       -9     
- Partials       18       19       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Mar 14, 2025
@itsjeyd itsjeyd moved this from Needs Triage to Ready for Review in Contributions Mar 14, 2025
@itsjeyd itsjeyd requested a review from a team March 14, 2025 08:41
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for doing this! I'm so happy to see it cleaned up :)

I wasn't sure how to test some of the things, e.g. the Calculator component that you changed from a class component to a function component. But the code looks good to me and the things I did test were working the same.

Comment on lines +29 to +31
const changeEquation = (value) => {
setEquation(value);
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit/optional: this function isn't really needed at all - can just use setEquation(event.target.value) directly.

@itsjeyd itsjeyd moved this from Ready for Review to In Eng Review in Contributions Apr 10, 2025
@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Apr 10, 2025
@bradenmacdonald
Copy link
Contributor

@KristinAoki Would you be able to merge this soon ? Or would you like me to? I'm worried we'll start to get more conflicts if we wait longer.

@jristau1984
Copy link
Contributor

@bradenmacdonald if you are able to take this over, please do. Thanks.

@bradenmacdonald bradenmacdonald force-pushed the KristinAoki/replace-intlShape-and-injectintl branch from 45df58a to 391096b Compare April 15, 2025 17:38
@bradenmacdonald
Copy link
Contributor

Rebased, and I figured out how to test the calculator - seems to be working fine. Gonna merge now.

@bradenmacdonald bradenmacdonald merged commit 903fe28 into master Apr 15, 2025
7 checks passed
@bradenmacdonald bradenmacdonald deleted the KristinAoki/replace-intlShape-and-injectintl branch April 15, 2025 17:45
@openedx-webhooks openedx-webhooks removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Apr 15, 2025
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants