-
Notifications
You must be signed in to change notification settings - Fork 243
refactor: change to useIntl #1634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change to useIntl #1634
Conversation
Thanks for the pull request, @KristinAoki! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@openedx/committers-frontend-app-learning this PR is ready to be reviewed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1634 +/- ##
==========================================
- Coverage 90.18% 90.18% -0.01%
==========================================
Files 339 338 -1
Lines 5810 5726 -84
Branches 1409 1379 -30
==========================================
- Hits 5240 5164 -76
+ Misses 552 543 -9
- Partials 18 19 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thanks for doing this! I'm so happy to see it cleaned up :)
I wasn't sure how to test some of the things, e.g. the Calculator
component that you changed from a class component to a function component. But the code looks good to me and the things I did test were working the same.
const changeEquation = (value) => { | ||
setEquation(value); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit/optional: this function isn't really needed at all - can just use setEquation(event.target.value)
directly.
@KristinAoki Would you be able to merge this soon ? Or would you like me to? I'm worried we'll start to get more conflicts if we wait longer. |
@bradenmacdonald if you are able to take this over, please do. Thanks. |
45df58a
to
391096b
Compare
Rebased, and I figured out how to test the calculator - seems to be working fine. Gonna merge now. |
Description
This PR replaces
injectIntl
andintlShape
withuseIntl
.injectIntl
andintlShape
are both deprecated. It should be noted that this PR skips the refactor in the following places:progress-tab
folderSection.jsx
SequenceLink.jsx
Each of these has an open PR that includes the refactor (#1619, #1632)