Skip to content

chore: upgrade fortawesome dependencies #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

regisb
Copy link
Contributor

@regisb regisb commented Apr 2, 2025

No description provided.

@openedx-webhooks
Copy link

Thanks for the pull request, @regisb!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (90f2e25) to head (c150bc9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #584   +/-   ##
=======================================
  Coverage   68.75%   68.75%           
=======================================
  Files          48       48           
  Lines         432      432           
  Branches       97       97           
=======================================
  Hits          297      297           
  Misses        132      132           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@regisb
Copy link
Contributor Author

regisb commented Apr 2, 2025

This is ready for review.

@adamstankiewicz
Copy link
Member

Given font-awesome is technically deprecated within Open edX per this Paragon ADR, I might recommend we consider understanding how we can migrate away from font-awesome here (in favor of Paragon's icons) vs. upgrading it.

@regisb
Copy link
Contributor Author

regisb commented Apr 2, 2025

I might recommend we consider understanding how we can migrate away from font-awesome here (in favor of Paragon's icons) vs. upgrading it.

I have no idea how to do that, as I'm not a frontend developer myself. The problem that we are facing right now is that frontend-header depends on a version of fortawesome that is different from other frontend apps. As a consequence, an additional package is installed inside @openedx/frontend-component-header/node_modules/@fortawesome. For most other packages it's not a big deal, but these particular packages use ~160MB of disk space.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: In Eng Review
Development

Successfully merging this pull request may close these issues.

3 participants