-
Notifications
You must be signed in to change notification settings - Fork 146
feat: add language selector component to header #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @Ang-m4! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@Ang-m4 I've added you to the openedx-triage team as you are covered under an entity CLA. This will mean that tests will run automatically when you submit a pull request in the future. Please look for an invitation in your email and accept it. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #586 +/- ##
==========================================
+ Coverage 68.75% 70.04% +1.29%
==========================================
Files 48 49 +1
Lines 432 454 +22
Branches 97 102 +5
==========================================
+ Hits 297 318 +21
- Misses 132 133 +1
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @e0d, thanks for catching that! Looks like I added an extra "s" to "style"... I'll go ahead and update the commit messages to follow the convention. Appreciate the heads-up!. |
f958c4f
to
14b8cc5
Compare
14b8cc5
to
48a1e4e
Compare
Language Selector Implementation
Description
This pull request proposes a new
LanguageSelector
component that enables users to change the site language using a paragon dropdown.Features
Changes
LanguageSelector.jsx
: Main component implementationLanguageSelector.scss
: Styling with media queriesLanguageSelector.test.jsx
: Testing logic for the componentindex.js
: Export file for the componentIntegration
The component is integrated into both header types:
LearningHeader.jsx
for the learning experienceHeaderBody.jsx
for StudioBoth implementations are conditional based on the
ENABLE_HEADER_LANG_SELECTOR
configuration flag, making it easy to enable/disable.Related Work
This implementation relies entirely on the proposed
LanguageManagement
feature. For more details, please refer to the related pull request: Language Management PR.