-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add python 3.12 support #258
base: main
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @BryanttV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
5b74e6e
to
7857e32
Compare
7857e32
to
2021bb8
Compare
.github/workflows/ci.yml
Outdated
@@ -37,7 +37,7 @@ jobs: | |||
run: tox | |||
|
|||
- name: Run coverage | |||
if: matrix.python-version == '3.11' && matrix.toxenv == 'django42' | |||
if: matrix.python-version == '3.12' && matrix.toxenv == 'django42' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we use the Python version used by the current release of the Open edX ecosystem, python 3.11 or are the services already using python 3.12? This question also applies to the other default changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, You're right. Done: fd79a6b
@@ -3,3 +3,4 @@ | |||
|
|||
django | |||
edx-opaque-keys[django] | |||
setuptools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More context on this change: openedx/edx-cookiecutters@293ae2f
Description
This PR adds support to Python 3.12.
assertDictContainsSubset
method was removed in Python 3.12. It was replaced withassertLessEqual(itemsA, itemsB)
Supporting information
Checklists
Check off if complete or not applicable:
Merge Checklist:
Post Merge:
finished.