feat(Prices): API: new filter on proof owner_consumption #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
commented
Mar 8, 2025
| @@ -31,6 +31,9 @@ class PriceFilter(django_filters.FilterSet): | |||
| field_name="proof__type", | |||
| choices=proof_constants.TYPE_CHOICES, | |||
| ) | |||
| proof__owner_consumption = django_filters.BooleanFilter( | |||
There was a problem hiding this comment.
actually I don't know if it's the right strategy...
because it'll be tricky to filter for the opposite ("community" prices).
maybe instead create a new custom filter - for instance proof__group that could be "consumption" or "community", and we would manage the custom filtering somewhere in the backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Similar to #741, and following #750
Add a new API price filter on
proof__owner_consumption