Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pytest config back to setup.cfg #2017

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Feb 10, 2025

A minimal attempt at what I reference here: #2004 (comment)

Resolves #1997

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.10%. Comparing base (14d16ae) to head (63d0745).
Report is 1 commits behind head on main.

Additional details and impacted files

@mattwthompson
Copy link
Member Author

This seems to resolve #1997, or at least prevents the tests from not being collected.

@mattwthompson mattwthompson marked this pull request as ready for review February 10, 2025 04:34
@mattwthompson mattwthompson linked an issue Feb 10, 2025 that may be closed by this pull request
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattwthompson - I really appreciate it, and it'll be good to have nightlies running again. I'll add a new issue to the backlog to complete the migration to pyproject.toml

@mattwthompson mattwthompson merged commit 9934858 into main Feb 11, 2025
13 checks passed
@mattwthompson mattwthompson deleted the revert-pytest-config branch February 11, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduled CI failing
2 participants