-
Notifications
You must be signed in to change notification settings - Fork 36
2.4.7-p8 Compatibility / Housekeeping / Merge Changes from PR 20 #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
7a7cc60
18d29eb
3224d7f
7a0cd54
f24ff02
4d3f5b6
8d657f4
439995d
69ab2cb
8fad440
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,12 @@ | ||
| mysql -u <user> -p<password> <database> < ./scripts/attributes.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/ee.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/cms.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/catalogrule.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/salesrule.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/category.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/product.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/cataloginventory.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/customer.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/quote.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/sales.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/wishlist.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/01_attributes.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/02_ee.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/03_cms.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/04_catalogrule.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/05_salesrule.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/06_category.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/07_product.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/08_cataloginventory.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/09_customer.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/10_quote.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/11_sales.sql | ||
| mysql -u <user> -p<password> <database> < ./scripts/12_wishlist.sql |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| -- | ||
| -- 01_attributes.sql | ||
| -- | ||
|
|
||
| -- Remove EE attributes | ||
|
|
||
| DELETE | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,8 @@ | ||
| -- | ||
| -- 04_catalogrule.sql | ||
| -- | ||
|
|
||
|
|
||
| -- Enable `rule_id` column for catalogrule | ||
|
|
||
| ALTER TABLE `catalogrule_customer_group` | ||
|
|
@@ -61,5 +66,7 @@ ALTER TABLE `catalogrule_website` | |
| -- ---------------- | ||
| -- Drop sequence -- | ||
| -- ---------------- | ||
| -- ALTER TABLE `magento_banner_catalogrule` | ||
| -- DROP FOREIGN KEY `MAGENTO_BANNER_CATRULE_RULE_ID_SEQUENCE_CATRULE_SEQUENCE_VAL`; | ||
|
Comment on lines
+69
to
+70
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we remove this commented query? The table magento_banner_catalogrule is removed in ee.sql
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. or add a short comment on top of it with the reason why |
||
|
|
||
| DROP TABLE `sequence_catalogrule`; | ||
| DROP TABLE IF EXISTS `sequence_catalogrule`; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,33 @@ | ||
| -- | ||
| -- 05_salesrule.sql | ||
| -- | ||
|
|
||
| -- | ||
| -- This procedure will give you the ability to drop a foreign key if it exists which MySQL/MariaDB can't do on its own. | ||
| -- Taken from: https://stackoverflow.com/questions/17161496/drop-foreign-key-only-if-it-exists | ||
| -- | ||
| DROP PROCEDURE IF EXISTS PROC_DROP_FOREIGN_KEY; | ||
| DELIMITER $$ | ||
| CREATE PROCEDURE PROC_DROP_FOREIGN_KEY(IN tableName VARCHAR(64), IN constraintName VARCHAR(64)) | ||
| BEGIN | ||
| IF EXISTS( | ||
| SELECT * FROM information_schema.table_constraints | ||
| WHERE | ||
| table_schema = DATABASE() AND | ||
| table_name = tableName AND | ||
| constraint_name = constraintName AND | ||
| constraint_type = 'FOREIGN KEY') | ||
| THEN | ||
| SET @query = CONCAT('ALTER TABLE ', tableName, ' DROP FOREIGN KEY ', constraintName, ';'); | ||
| PREPARE stmt FROM @query; | ||
| EXECUTE stmt; | ||
| DEALLOCATE PREPARE stmt; | ||
| END IF; | ||
| END$$ | ||
| DELIMITER ; | ||
|
|
||
|
|
||
|
|
||
| DROP TABLE IF EXISTS | ||
| `magento_banner_salesrule`, | ||
| `magento_reward_salesrule`, | ||
|
|
@@ -70,6 +100,9 @@ ALTER TABLE `salesrule_product_attribute` | |
| ADD PRIMARY KEY (`rule_id`,`website_id`,`customer_group_id`,`attribute_id`), | ||
| DROP COLUMN `row_id`; | ||
|
|
||
| -- Clean any orphans | ||
| DELETE FROM salesrule_label WHERE rule_id = 0; | ||
|
|
||
| -- Label Attribute | ||
| ALTER TABLE `salesrule_label` | ||
| DROP FOREIGN KEY `SALESRULE_LABEL_ROW_ID_SALESRULE_ROW_ID`, | ||
|
|
@@ -78,6 +111,18 @@ ALTER TABLE `salesrule_label` | |
| DROP COLUMN `row_id`; | ||
|
|
||
| -- Salesrule | ||
| CALL PROC_DROP_FOREIGN_KEY("salesrule_label", "SALESRULE_LABEL_ROW_ID_SALESRULE_ROW_ID"); | ||
|
|
||
| -- Amasty related | ||
| CALL PROC_DROP_FOREIGN_KEY("amasty_ampromo_rule", "AMASTY_AMPROMO_RULE_SALESRULE_ID_SALESRULE_ROW_ID"); | ||
| CALL PROC_DROP_FOREIGN_KEY("amasty_amrules_rule", "AMASTY_AMRULES_RULE_SALESRULE_ID_SALESRULE_ROW_ID"); | ||
| CALL PROC_DROP_FOREIGN_KEY("amasty_amrules_usage_limit", "AMASTY_AMRULES_USAGE_LIMIT_SALESRULE_ID_SALESRULE_ROW_ID"); | ||
| CALL PROC_DROP_FOREIGN_KEY("amasty_free_gift_timer_timer_data", "AMASTY_FREE_GIFT_TIMER_TIMER_DATA_SALESRULE_ID_SALESRULE_ROW_ID"); | ||
| CALL PROC_DROP_FOREIGN_KEY("amasty_amrules_usage_counter", "AMASTY_AMRULES_USAGE_COUNTER_SALESRULE_ID_SALESRULE_RULE_ID"); | ||
| CALL PROC_DROP_FOREIGN_KEY("amasty_banners_lite_banner_data", "AMASTY_BANNERS_LITE_BANNER_DATA_SALESRULE_ID_SALESRULE_RULE_ID"); | ||
| CALL PROC_DROP_FOREIGN_KEY("amasty_banners_lite_rule", "AMASTY_BANNERS_LITE_RULE_SALESRULE_ID_SALESRULE_ROW_ID"); | ||
| CALL PROC_DROP_FOREIGN_KEY("amasty_banners_lite_rule", "AMASTY_BANNERS_LITE_RULE_SALESRULE_ID_SALESRULE_RULE_ID"); | ||
|
Comment on lines
+116
to
+124
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. anything related to third party module should be moved to a dedicated file so it's up to anyone to run this one or not (ex: 99_amasty.sql)
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. your problem there will be that the need running early on so that the products one can run without issue (maybe 00_amasty.sql instead) |
||
|
|
||
| ALTER TABLE `salesrule` | ||
| DROP FOREIGN KEY `SALESRULE_RULE_ID_SEQUENCE_SALESRULE_SEQUENCE_VALUE`, | ||
| DROP COLUMN `row_id`, | ||
|
|
@@ -97,13 +142,26 @@ ALTER TABLE `salesrule_product_attribute` | |
| -- ---------------- | ||
| -- Drop sequence -- | ||
| -- ---------------- | ||
| -- We need to clean up the salesrule_coupon table before dropping the sequence_salesrule table | ||
| DELETE FROM salesrule_coupon | ||
| WHERE rule_id NOT IN (SELECT rule_id FROM salesrule); | ||
|
|
||
| ALTER TABLE `salesrule_coupon` | ||
| DROP FOREIGN KEY `SALESRULE_COUPON_RULE_ID_SEQUENCE_SALESRULE_SEQUENCE_VALUE`, | ||
| ADD CONSTRAINT `SALESRULE_COUPON_RULE_ID_SALESRULE_RULE_ID` FOREIGN KEY (`rule_id`) REFERENCES `salesrule` (`rule_id`); | ||
| ALTER TABLE `salesrule_customer` | ||
| DROP FOREIGN KEY `SALESRULE_CUSTOMER_RULE_ID_SEQUENCE_SALESRULE_SEQUENCE_VALUE`, | ||
| ADD CONSTRAINT `SALESRULE_CUSTOMER_RULE_ID_SALESRULE_RULE_ID` FOREIGN KEY (`rule_id`) REFERENCES `salesrule` (`rule_id`); | ||
|
|
||
| -- | ||
| -- Already done above in line 103. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. isn't it line 111? We should regroup the operation over the same table in the same group of queries for more clarity |
||
| -- | ||
| -- ALTER TABLE `salesrule_label` | ||
| -- CHANGE `row_id` `rule_id` INT(10) UNSIGNED NOT NULL COMMENT 'Rule ID'; | ||
|
|
||
| DELETE FROM salesrule_label | ||
| WHERE rule_id NOT IN (SELECT rule_id FROM salesrule); | ||
|
|
||
| ALTER TABLE `salesrule_label` | ||
| ADD CONSTRAINT `SALESRULE_LABEL_RULE_ID_SALESRULE_RULE_ID` FOREIGN KEY (`rule_id`) REFERENCES `salesrule` (`rule_id`); | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,31 @@ | ||
| -- | ||
| -- 07_product.sql | ||
| -- | ||
|
|
||
| -- | ||
| -- This procedure will give you the ability to drop a foreign key if it exists which MySQL/MariaDB can't do on its own. | ||
| -- Taken from: https://stackoverflow.com/questions/17161496/drop-foreign-key-only-if-it-exists | ||
| -- | ||
| DROP PROCEDURE IF EXISTS PROC_DROP_FOREIGN_KEY; | ||
| DELIMITER $$ | ||
| CREATE PROCEDURE PROC_DROP_FOREIGN_KEY(IN tableName VARCHAR(64), IN constraintName VARCHAR(64)) | ||
| BEGIN | ||
| IF EXISTS( | ||
| SELECT * FROM information_schema.table_constraints | ||
| WHERE | ||
| table_schema = DATABASE() AND | ||
| table_name = tableName AND | ||
| constraint_name = constraintName AND | ||
| constraint_type = 'FOREIGN KEY') | ||
| THEN | ||
| SET @query = CONCAT('ALTER TABLE ', tableName, ' DROP FOREIGN KEY ', constraintName, ';'); | ||
| PREPARE stmt FROM @query; | ||
| EXECUTE stmt; | ||
| DEALLOCATE PREPARE stmt; | ||
| END IF; | ||
| END$$ | ||
| DELIMITER ; | ||
|
|
||
| -- Enable `entity_id` column for catalog product entity | ||
|
|
||
| ALTER TABLE `catalog_product_entity_datetime` | ||
|
|
@@ -288,6 +316,8 @@ ALTER TABLE `catalog_product_bundle_selection` | |
| ADD CONSTRAINT `CAT_PRD_BNDL_SELECTION_OPT_ID_CAT_PRD_BNDL_OPT_OPT_ID` FOREIGN KEY (`option_id`) REFERENCES `catalog_product_bundle_option` (`option_id`) ON DELETE CASCADE ON UPDATE RESTRICT; | ||
|
|
||
| ALTER TABLE `catalog_product_bundle_selection_price` | ||
| -- DROP INDEX `CATALOG_PRODUCT_BUNDLE_SELECTION_PRICE_WEBSITE_ID`, -- we do not need to remove this index | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could you add a quick explanation?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we could remove this line IMO |
||
| -- ADD CONSTRAINT `CATALOG_PRODUCT_BUNDLE_SELECTION_PRICE_WEBSITE_ID` FOREIGN KEY (`website_id`) REFERENCES `store_website` (`website_id`) ON DELETE CASCADE ON UPDATE RESTRICT, | ||
| ADD CONSTRAINT `FK_DCF37523AA05D770A70AA4ED7C2616E4` FOREIGN KEY (`selection_id`) REFERENCES `catalog_product_bundle_selection` (`selection_id`) ON DELETE CASCADE ON UPDATE RESTRICT; | ||
|
|
||
| -- ------------------------------------------------------------------ | ||
|
|
@@ -352,18 +382,18 @@ ALTER TABLE `catalog_product_entity_varchar` | |
| ALTER TABLE `catalog_product_entity_media_gallery_value_to_entity` | ||
| DROP FOREIGN KEY `CAT_PRD_ENTT_MDA_GLR_VAL_TO_ENTT_ROW_ID_CAT_PRD_ENTT_ROW_ID`, | ||
| DROP INDEX `CAT_PRD_ENTT_MDA_GLR_VAL_TO_ENTT_ROW_ID_CAT_PRD_ENTT_ROW_ID`, | ||
| ADD CONSTRAINT `CAT_PRD_ENTT_MDA_GLR_VAL_TO_ENTT_VAL_ID_ENTT_ID` UNIQUE KEY (`value_id`,`entity_id`), | ||
| DROP PRIMARY KEY, | ||
| ADD PRIMARY KEY (`value_id`,`entity_id`), | ||
| DROP COLUMN `row_id`; | ||
| DROP COLUMN `row_id`, | ||
| ADD PRIMARY KEY (`value_id`, `entity_id`), | ||
| ADD CONSTRAINT `CAT_PRD_ENTT_MDA_GLR_VAL_TO_ENTT_VAL_ID_ENTT_ID` UNIQUE KEY (`value_id`,`entity_id`); | ||
|
|
||
| -- Gallery value | ||
| ALTER TABLE `catalog_product_entity_media_gallery_value` | ||
| DROP FOREIGN KEY `CAT_PRD_ENTT_MDA_GLR_VAL_ROW_ID_CAT_PRD_ENTT_ROW_ID`, | ||
| DROP INDEX `CATALOG_PRODUCT_ENTITY_MEDIA_GALLERY_VALUE_ROW_ID`, | ||
| DROP INDEX `CAT_PRD_ENTT_MDA_GLR_VAL_ROW_ID_VAL_ID_STORE_ID`, | ||
| DROP INDEX `CAT_PRD_ENTT_MDA_GLR_VAL_ROW_ID_VAL_ID_STORE_ID`, | ||
| ADD INDEX `CATALOG_PRODUCT_ENTITY_MEDIA_GALLERY_VALUE_ENTITY_ID` (`entity_id`), | ||
| ADD CONSTRAINT `CAT_PRD_ENTT_MDA_GLR_VAL_ENTT_ID_VAL_ID_STORE_ID` UNIQUE KEY (`entity_id`,`value_id`,`store_id`), | ||
| ADD INDEX `CAT_PRD_ENTT_MDA_GLR_VAL_ENTT_ID_VAL_ID_STORE_ID` (`entity_id`,`value_id`,`store_id`), | ||
| DROP COLUMN `row_id`; | ||
|
|
||
| -- Gallery | ||
|
|
@@ -382,7 +412,8 @@ ALTER TABLE `catalog_product_entity_tier_price` | |
| ADD CONSTRAINT `UNQ_E8AB433B9ACB00343ABB312AD2FAB087` UNIQUE KEY (`entity_id`,`all_groups`,`customer_group_id`,`qty`,`website_id`), | ||
| DROP COLUMN `row_id`; | ||
|
|
||
| -- Entity | ||
| -- Entity For some reason, FOREIGN KEY `CAT_PRD_SPR_ATTR_PRD_ID_CAT_PRD_ENTT_ROW_ID was not removed. We need to run it again. | ||
| -- ALTER TABLE `catalog_product_super_attribute` DROP FOREIGN KEY `CAT_PRD_SPR_ATTR_PRD_ID_CAT_PRD_ENTT_ROW_ID`; | ||
| SET FOREIGN_KEY_CHECKS = 0; | ||
| ALTER TABLE `catalog_product_entity` | ||
| DROP INDEX `CATALOG_PRODUCT_ENTITY_ENTITY_ID_CREATED_IN_UPDATED_IN`, | ||
|
|
@@ -464,11 +495,13 @@ ALTER TABLE `catalog_product_website` | |
| DELETE c.* FROM `catalog_url_rewrite_product_category` c LEFT JOIN catalog_product_entity p ON c.product_id = p.entity_id WHERE p.entity_id IS NULL; | ||
| ALTER TABLE `catalog_url_rewrite_product_category` | ||
| DROP FOREIGN KEY `CAT_URL_REWRITE_PRD_CTGR_PRD_ID_SEQUENCE_PRD_SEQUENCE_VAL`, | ||
| -- DROP FOREIGN KEY `FK_BB79E64705D7F17FE181F23144528FC8`, -- maybe we have to remove this key instead of the previous one | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. was it related to your tests?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. that came from the original other PR
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It may depends on builds, sometimes the FK are not generated with the name from the declarative schema (or setup schema)
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. might be worth wrapping it in the func then, so it can run if it's there, otherwise ignore it
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. agreed! but I'm not sure that this key name refer to the same FK (I should browse my projects and check) |
||
| ADD CONSTRAINT `CAT_URL_REWRITE_PRD_CTGR_PRD_ID_CAT_PRD_ENTT_ENTT_ID` FOREIGN KEY (`product_id`) REFERENCES `catalog_product_entity` (`entity_id`) ON DELETE CASCADE ON UPDATE RESTRICT; | ||
|
|
||
| DELETE FROM `cataloginventory_stock_item` WHERE `product_id` NOT IN (SELECT `entity_id` FROM `catalog_product_entity`); | ||
| ALTER TABLE `cataloginventory_stock_item` | ||
| DROP FOREIGN KEY `CATINV_STOCK_ITEM_PRD_ID_SEQUENCE_PRD_SEQUENCE_VAL`, | ||
| -- DROP FOREIGN KEY `CATINV_STOCK_ITEM_STOCK_ID_CATINV_STOCK_STOCK_ID`, -- maybe we have to remove this key instead of the previous one | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. was it related to your tests?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. that came from the original other PR
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, my bad didn't paid attention to it! it's safe to remove this line, we should'nt remove the relation for the stock ID anyway
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @thomas-kl1 no worries :D |
||
| ADD CONSTRAINT `CATINV_STOCK_ITEM_PRD_ID_CAT_PRD_ENTT_ENTT_ID` FOREIGN KEY (`product_id`) REFERENCES `catalog_product_entity` (`entity_id`) ON DELETE CASCADE ON UPDATE RESTRICT; | ||
|
|
||
| ALTER TABLE `product_alert_price` | ||
|
|
@@ -507,4 +540,10 @@ ALTER TABLE `wishlist_item` | |
| DROP FOREIGN KEY `WISHLIST_ITEM_PRODUCT_ID_SEQUENCE_PRODUCT_SEQUENCE_VALUE`, | ||
| ADD CONSTRAINT `WISHLIST_ITEM_PRODUCT_ID_CATALOG_PRODUCT_ENTITY_ENTITY_ID` FOREIGN KEY (`product_id`) REFERENCES `catalog_product_entity` (`entity_id`) ON DELETE CASCADE ON UPDATE RESTRICT; | ||
|
|
||
| -- DROP FOREIGN KEY on the sequence table | ||
|
|
||
| CALL PROC_DROP_FOREIGN_KEY("magento_targetrule_product", "MAGENTO_TARGETRULE_PRD_PRD_ID_SEQUENCE_PRD_SEQUENCE_VAL"); | ||
| CALL PROC_DROP_FOREIGN_KEY("email_catalog", "EMAIL_CATALOG_PRODUCT_ID_SEQUENCE_PRODUCT_SEQUENCE_VALUE"); | ||
| CALL PROC_DROP_FOREIGN_KEY("magento_giftregistry_item", "MAGENTO_GIFTREGISTRY_ITEM_PRD_ID_SEQUENCE_PRD_SEQUENCE_VAL"); | ||
|
|
||
| DROP TABLE `sequence_product_bundle_selection`,`sequence_product_bundle_option`,`sequence_product`; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| -- | ||
| -- 08_cataloginventory.sql | ||
| -- | ||
|
|
||
| ALTER TABLE `cataloginventory_stock_item` | ||
| DROP COLUMN `deferred_stock_update`, | ||
| DROP COLUMN `use_config_deferred_stock_update`; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| -- | ||
| -- 09_customer.sql | ||
| -- | ||
|
|
||
| ALTER TABLE `customer_eav_attribute` | ||
| DROP COLUMN `is_used_for_customer_segment`; | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you uppercase SQL keywords please? (UPDATE + SET)
Also what situation could lead to this one? (a short comment on top of the query is fine)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another that came from the other PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should remove this line