Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8350955: Fix repetitions of the word "the" in runtime component comments #23857

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Mar 3, 2025

Hi all,

please review this trivial change that fixes "the the" repetitions in the
runtime related sources.

If you think it's not worth fixing, I am okay with that and just retract the change.

Testing: gha

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8350955: Fix repetitions of the word "the" in runtime component comments (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23857/head:pull/23857
$ git checkout pull/23857

Update a local copy of the PR:
$ git checkout pull/23857
$ git pull https://git.openjdk.org/jdk.git pull/23857/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23857

View PR using the GUI difftool:
$ git pr show -t 23857

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23857.diff

Using Webrev

Link to Webrev Comment

Hi all,

  please review this trivial change that fixes "the the" repetitions in the
runtime related sources.

If you think it's not worth fixing, I am okay with that and just retract the change.

Testing: gha

Thanks,
  Thomas
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 3, 2025

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 3, 2025

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350955: Fix repetitions of the word "the" in runtime component comments

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • c988d7d: 8350767: Fix -Wzero-as-null-pointer-constant warnings in nsk jni stress tests
  • 67dfdfa: 8350623: Fix -Wzero-as-null-pointer-constant warnings in nsk native test utilities
  • 4a51c61: 8350567: NMT: update VMATree::register_mapping to copy the existing tag of the region
  • db69ec9: 8344009: Improve compiler memory statistics
  • f47232a: 8350954: Fix repetitions of the word "the" in gc component comments
  • 30b0c60: 8350956: Fix repetitions of the word "the" in compiler component comments
  • 8b0468f: 8315488: Remove outdated and unused ciReplay support from SA

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8350955 8350955: Fix repetitions of the word "the" in runtime component comments Mar 3, 2025
@openjdk
Copy link

openjdk bot commented Mar 3, 2025

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@tschatzl tschatzl marked this pull request as ready for review March 3, 2025 11:34
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 3, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 3, 2025

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good plus trivial and I don't think it'll cause a conflict for PR #23421

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 3, 2025
@tschatzl
Copy link
Contributor Author

tschatzl commented Mar 3, 2025

Does not look to me either a problem for PR #23421. Will push. Thanks @coleenp !

/integrate

@openjdk
Copy link

openjdk bot commented Mar 3, 2025

Going to push as commit 3602c8c.
Since your change was applied there have been 7 commits pushed to the master branch:

  • c988d7d: 8350767: Fix -Wzero-as-null-pointer-constant warnings in nsk jni stress tests
  • 67dfdfa: 8350623: Fix -Wzero-as-null-pointer-constant warnings in nsk native test utilities
  • 4a51c61: 8350567: NMT: update VMATree::register_mapping to copy the existing tag of the region
  • db69ec9: 8344009: Improve compiler memory statistics
  • f47232a: 8350954: Fix repetitions of the word "the" in gc component comments
  • 30b0c60: 8350956: Fix repetitions of the word "the" in compiler component comments
  • 8b0468f: 8315488: Remove outdated and unused ciReplay support from SA

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 3, 2025
@openjdk openjdk bot closed this Mar 3, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 3, 2025
@openjdk
Copy link

openjdk bot commented Mar 3, 2025

@tschatzl Pushed as commit 3602c8c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants