8352423: RISC-V: simplify DivI/L ModI/L

[Hamlin-Li]

Hi,
Can you help to review this patch?

Currently, implementation of DivI/L and ModI/L are overcomplicated, could and should be simplified.
And, also enable some DivI/L and ModI/L related tests.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352423: RISC-V: simplify DivI/L ModI/L (Enhancement - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Ludovic Henry (@luhenry - Committer)
• Robbin Ehn (@robehn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24119/head:pull/24119
$ git checkout pull/24119

Update a local copy of the PR:
$ git checkout pull/24119
$ git pull https://git.openjdk.org/jdk.git pull/24119/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24119

View PR using the GUI difftool:
$ git pr show -t 24119

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24119.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352423: RISC-V: simplify DivI/L ModI/L

Reviewed-by: fyang, luhenry, rehn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• 28250f8: 8352151: Fix display issues in javadoc-generated docs
• b32be18: 8352178: Add precondition in VMThread::execute to prevent deadlock
• 07667ca: 8352506: Simplify make/test/JtregNativeHotspot.gmk
• b545b9e: 8352584: [Backout] G1: Pinned regions with pinned objects only reachable by native code crash VM
• 1c0fa0a: 8352512: TestVectorZeroCount: counter not reset between iterations
• 466f82a: 8314999: IR framework fails to detect allocation
• 06ba6cf: 8329173: LCMS_CFLAGS from configure are lost
• 56038fb: 8352317: Assertion failure during size estimation of BoxLockNode with -XX:+UseAPX
• 2bc4f64: 8335708: C2: Compile::verify_graph_edges must start at root and safepoints, just like CCP traversal
• 9a17a6f: 8350749: Upgrade JLine to 3.29.0
• ... and 27 more: https://git.openjdk.org/jdk/compare/b891bfa7e67c21478475642e2bfa2cdc65a3bffe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (64d1ad47)
• 00: Full (85b880be)

[RealFYang]

Thanks for the cleanup!

[Hamlin-Li]

Thanks for the cleanup!

Thank you!

[robehn]

Nice removing 100 LOC, thank you!

[Hamlin-Li]

Thank you @luhenry @robehn !

[Hamlin-Li]

/integrate

[openjdk]

Going to push as commit ac760dd.
Since your change was applied there have been 40 commits pushed to the master branch:

• d1cf232: 8352248: Check if CMoveX is supported
• 2b55979: 8352529: RISC-V: enable loopopts tests
• 8469458: 8352511: Show additional level of headings in table of contents
• 28250f8: 8352151: Fix display issues in javadoc-generated docs
• b32be18: 8352178: Add precondition in VMThread::execute to prevent deadlock
• 07667ca: 8352506: Simplify make/test/JtregNativeHotspot.gmk
• b545b9e: 8352584: [Backout] G1: Pinned regions with pinned objects only reachable by native code crash VM
• 1c0fa0a: 8352512: TestVectorZeroCount: counter not reset between iterations
• 466f82a: 8314999: IR framework fails to detect allocation
• 06ba6cf: 8329173: LCMS_CFLAGS from configure are lost
• ... and 30 more: https://git.openjdk.org/jdk/compare/b891bfa7e67c21478475642e2bfa2cdc65a3bffe...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Hamlin-Li Pushed as commit ac760dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.