Skip to content

8352512: TestVectorZeroCount: counter not reset between iterations #24134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dbriemann
Copy link
Contributor

@dbriemann dbriemann commented Mar 20, 2025


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8352512: TestVectorZeroCount: counter not reset between iterations (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24134/head:pull/24134
$ git checkout pull/24134

Update a local copy of the PR:
$ git checkout pull/24134
$ git pull https://git.openjdk.org/jdk.git pull/24134/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24134

View PR using the GUI difftool:
$ git pr show -t 24134

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24134.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 20, 2025

👋 Welcome back dbriemann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 20, 2025

@dbriemann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352512: TestVectorZeroCount: counter not reset between iterations

Reviewed-by: mdoerr, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 2bc4f64: 8335708: C2: Compile::verify_graph_edges must start at root and safepoints, just like CCP traversal
  • 9a17a6f: 8350749: Upgrade JLine to 3.29.0
  • 91836e1: 8352276: Skip jtreg tests using native executable with libjvm.so/libjli.so dependencies on static JDK

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Mar 20, 2025

@dbriemann The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing it!

@dbriemann dbriemann marked this pull request as ready for review March 20, 2025 14:38
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 20, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 20, 2025

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, too.

@dbriemann
Copy link
Contributor Author

Thank you both for your reviews!
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 20, 2025
@openjdk
Copy link

openjdk bot commented Mar 20, 2025

@dbriemann
Your change (at version a4588f1) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 21, 2025

Going to push as commit 1c0fa0a.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 466f82a: 8314999: IR framework fails to detect allocation
  • 06ba6cf: 8329173: LCMS_CFLAGS from configure are lost
  • 56038fb: 8352317: Assertion failure during size estimation of BoxLockNode with -XX:+UseAPX
  • 2bc4f64: 8335708: C2: Compile::verify_graph_edges must start at root and safepoints, just like CCP traversal
  • 9a17a6f: 8350749: Upgrade JLine to 3.29.0
  • 91836e1: 8352276: Skip jtreg tests using native executable with libjvm.so/libjli.so dependencies on static JDK

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 21, 2025
@openjdk openjdk bot closed this Mar 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 21, 2025
@openjdk
Copy link

openjdk bot commented Mar 21, 2025

@TheRealMDoerr @dbriemann Pushed as commit 1c0fa0a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dbriemann dbriemann deleted the dlb/fix_TestVectorZeroCount branch March 21, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants