8341095: Possible overflow in os::Posix::print_uptime_info

[gerard-ziemski]

This is a trivial change that will quiet Xcode only visual warning in os_posix.cpp file.

There are 31,536,000 seconds in a year, so if int is 32bits, then we have MAX int value of 2,147,483,647 so it would overflow in 68 years - unlikely to affect anyone.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8341095: Possible overflow in os::Posix::print_uptime_info (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24140/head:pull/24140
$ git checkout pull/24140

Update a local copy of the PR:
$ git checkout pull/24140
$ git pull https://git.openjdk.org/jdk.git pull/24140/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24140

View PR using the GUI difftool:
$ git pr show -t 24140

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24140.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gziemski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@gerard-ziemski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341095: Possible overflow in os::Posix::print_uptime_info

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@gerard-ziemski The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (c9d07aa6)
• 01: Full - Incremental (0ca5615f)
• 00: Full (88d0f7a4)

[dholmes-ora]

Okay and trivial.

Thanks

[gerard-ziemski]

Thank you!

[gerard-ziemski]

/integrate

[openjdk]

Going to push as commit 77fff61.
Since your change was applied there have been 130 commits pushed to the master branch:

• 9128ec6: 8352935: Launcher should not add $JDK/../lib to LD_LIBRARY_PATH
• 27c8d9d: 8352686: Opensource JInternalFrame tests - series3
• 66435c2: 8352684: Opensource JInternalFrame tests - series1
• 353e173: 8219408: Tests should handle ${} in the view of jtreg "smart action"
• 26bb183: 8352621: MatchException from backwards incompatible change to switch expressions
• e8c9e5c: 8353231: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad still fails intermittently
• 6ab1647: 8353637: ZGC: Discontiguous memory reservation is broken on Windows
• c494a00: 8353559: Restructure CollectedHeap error printing
• 32d6d03: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java
• 39549f8: 8352116: Deadlock with GCLocker and JVMTI after JDK-8192647
• ... and 120 more: https://git.openjdk.org/jdk/compare/c0292203794bf3a8bfb02eac062e226ef2d07ee1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@gerard-ziemski Pushed as commit 77fff61.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.