Skip to content

8152293: Incomplete fraction reduction in getValueAsString() for TIFFTag.TIFF_RATIONAL, TIFFTag.TIFF_SRATIONAL #24141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Mar 20, 2025

Remove from TIFFField.getValueAsString the rudimentary reduction in terms in the conversion of RATIONAL and SRATIONAL field values to a string. Also, add a test.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8152293: Incomplete fraction reduction in getValueAsString() for TIFFTag.TIFF_RATIONAL, TIFFTag.TIFF_SRATIONAL (Bug - P4) ⚠️ Issue is not open.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24141/head:pull/24141
$ git checkout pull/24141

Update a local copy of the PR:
$ git checkout pull/24141
$ git pull https://git.openjdk.org/jdk.git pull/24141/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24141

View PR using the GUI difftool:
$ git pr show -t 24141

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24141.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 20, 2025

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 20, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 20, 2025
@openjdk
Copy link

openjdk bot commented Mar 20, 2025

@bplb The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Mar 20, 2025

Webrevs

@bplb
Copy link
Member Author

bplb commented Mar 20, 2025

If this change is deemed acceptable, then a CSR will be filed to remove the following sentence from the specification of TIFFField.getValueAsString:

If the numerator of a TIFFTag.TIFF_RATIONAL or TIFF_SRATIONAL is an integral
multiple of the denominator, then the value is represented as "q/1" where q
is the quotient of the numerator and denominator.

@bplb
Copy link
Member Author

bplb commented Mar 24, 2025

The corresponding issue is closed as Won't Fix so this PR Is being withdrawn.

@bplb bplb closed this Mar 24, 2025
@bplb bplb deleted the TIFFField-RATIONAL-8152293 branch March 24, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant