Skip to content

8352292: Implement NMT tags using hashtables #24142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

gerard-ziemski
Copy link

@gerard-ziemski gerard-ziemski commented Mar 20, 2025

This is a follow-up to #21843. Here we are focusing on removing the mem tag paremeter with default value of mtNone, to force everyone to provide mem tag, if known.

I tried to fill in tag, when I was pretty certain that I had the right type.

At least one more follow-up will be needed after this, to change the remaining mtNone to valid values.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8352292: Implement NMT tags using hashtables (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24142/head:pull/24142
$ git checkout pull/24142

Update a local copy of the PR:
$ git checkout pull/24142
$ git pull https://git.openjdk.org/jdk.git pull/24142/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24142

View PR using the GUI difftool:
$ git pr show -t 24142

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24142.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 20, 2025

👋 Welcome back gziemski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 20, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Mar 20, 2025

@gerard-ziemski The following labels will be automatically applied to this pull request:

  • hotspot
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@gerard-ziemski gerard-ziemski deleted the JDK-8352292 branch March 21, 2025 19:44
@gerard-ziemski gerard-ziemski restored the JDK-8352292 branch May 1, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant