Skip to content

8298783: java/lang/ref/FinalizerHistogramTest.java failed with "RuntimeException: MyObject is not found in test output" #24143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

8298783: java/lang/ref/FinalizerHistogramTest.java failed with "RuntimeException: MyObject is not found in test output" #24143

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
64f88cd
test reliability improvements
bchristi-git Mar 20, 2025
efbe07b
rename counter variables to use 'Count'
bchristi-git Mar 21, 2025
78f334a
'return' not needed in lambda
bchristi-git Mar 21, 2025
d104107
convert to WeakRefs, use a RefQ, print ForceGC results
bchristi-git Mar 28, 2025
cfbb423
Merge branch 'master' into 8298783
bchristi-git Apr 25, 2025
3a7d12b
Merge branch 'master' into 8298783
bchristi-git Apr 29, 2025
10c8a9e
convert test to use WhiteBox
bchristi-git Apr 29, 2025
0468fe7
loop until ref proc returns false
bchristi-git Apr 30, 2025
88b2687
remove unneeded 'trappedCount'
bchristi-git May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 27 additions & 14 deletions test/jdk/java/lang/ref/FinalizerHistogramTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2015, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand All @@ -21,8 +21,9 @@
* questions.
*/

import java.util.concurrent.TimeUnit;
import java.util.concurrent.locks.Condition;
import jdk.test.whitebox.WhiteBox;

import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.locks.ReentrantLock;

import java.lang.reflect.Method;
Expand All @@ -32,37 +33,49 @@
* @test
* @summary Unit test for FinalizerHistogram
* @modules java.base/java.lang.ref:open
* @run main FinalizerHistogramTest
* @library /test/lib
* @build jdk.test.whitebox.WhiteBox
* @run driver jdk.test.lib.helpers.ClassFileInstaller jdk.test.whitebox.WhiteBox
* @run main/othervm
* -Xbootclasspath/a:.
* -XX:+UnlockDiagnosticVMOptions
* -XX:+WhiteBoxAPI
* FinalizerHistogramTest
*/

public class FinalizerHistogramTest {
static ReentrantLock lock = new ReentrantLock();
static volatile int wasInitialized = 0;
static volatile int wasTrapped = 0;
static final int objectsCount = 1000;
static final AtomicInteger initializedCount = new AtomicInteger(0);
static final int OBJECTS_COUNT = 1000;

static WhiteBox wb;

static class MyObject {
public MyObject() {
// Make sure object allocation/deallocation is not optimized out
wasInitialized += 1;
initializedCount.incrementAndGet();
}

protected void finalize() {
// Trap the object in a finalization queue
wasTrapped += 1;
lock.lock();
}
}

public static void main(String[] argvs) {
public static void main(String[] argvs) throws InterruptedException {
try {
lock.lock();
for(int i = 0; i < objectsCount; ++i) {
for(int i = 0; i < OBJECTS_COUNT; ++i) {
new MyObject();
}
System.out.println("Objects intialized: " + objectsCount);
System.gc();
while(wasTrapped < 1);
System.out.println("Objects intialized: " + initializedCount.get());
wb = WhiteBox.getWhiteBox();
wb.fullGC();
boolean refProResult;
do {
refProResult = wb.waitForReferenceProcessing();
System.out.println("waitForReferenceProcessing returned: " + refProResult);
} while (refProResult);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the spammy output? Why not just

while (wb.waitForReferenceProcessing()) {}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, the test just it prints a single line:
waitForReferenceProcessing returned: false
and I expect this to continue to be true.

For intermittently failing tests, I'm inclined to add a little extra output as long as I'm fiddling with it anyway. That way, if the test ever starts failing again, we have some (hopefully useful) clues about what happened.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, the test just it prints a single line: waitForReferenceProcessing returned: false and I expect this to continue to be true.

If reference processing is being slow because of load, that will be different.

For intermittently failing tests, I'm inclined to add a little extra output as long as I'm fiddling with it anyway. That way, if the test ever starts failing again, we have some (hopefully useful) clues about what happened.

OK.


Class<?> klass = Class.forName("java.lang.ref.FinalizerHistogram");

Expand Down