Skip to content

modified ClassfileBenchmark #24297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

asotona
Copy link
Member

@asotona asotona commented Mar 28, 2025

modified ClassfileBenchmark to compare performance of direct MemoryModel impl with memory copy


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #24139 must be integrated first

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24297/head:pull/24297
$ git checkout pull/24297

Update a local copy of the PR:
$ git checkout pull/24297
$ git pull https://git.openjdk.org/jdk.git pull/24297/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24297

View PR using the GUI difftool:
$ git pr show -t 24297

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24297.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2025

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into pr/24139 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

⚠️ @asotona a branch with the same name as the source branch for this pull request (pr/24139) is present in the target repository. If you eventually integrate this pull request then the branch pr/24139 in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the pr/24139 branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f pr/24139 29e8872cf41b5e8c610c8249bc250a34a3ad480c
$ git push -f origin pr/24139

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

@asotona The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@asotona asotona marked this pull request as draft March 28, 2025 15:55
@asotona asotona closed this Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant