8343739: Test java/awt/event/KeyEvent/ExtendedKeyCode/ExtendedKeyCodeTest.java failed: Wrong extended key code

[alisenchung]

Test was failing on Ubuntu, looks to be a synchronous error in the test so I rewrote it to improve stability.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8343739: Test java/awt/event/KeyEvent/ExtendedKeyCode/ExtendedKeyCodeTest.java failed: Wrong extended key code (Bug - P4)

Reviewers

• Phil Race (@prrace - Reviewer) Review applies to 711bd81f
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24885/head:pull/24885
$ git checkout pull/24885

Update a local copy of the PR:
$ git checkout pull/24885
$ git pull https://git.openjdk.org/jdk.git pull/24885/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24885

View PR using the GUI difftool:
$ git pr show -t 24885

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24885.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343739: Test java/awt/event/KeyEvent/ExtendedKeyCode/ExtendedKeyCodeTest.java failed: Wrong extended key code

Reviewed-by: serb, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 354 new commits pushed to the master branch:

• 303f410: 8355708: Two Float16 IR tests fail after JDK-8345125
• c23469d: 8355340: GenShen: Remove unneeded log messages related to remembered set write table
• b6b5ac1: 8348351: Improve lazy initialization of the available currencies set
• ... and 351 more: https://git.openjdk.org/jdk/compare/f98af0ad617a445362859e58af48258bfd5bed03...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alisenchung The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (efcc2a77)
• 02: Full - Incremental (711bd81f)
• 01: Full - Incremental (2199d038)
• 00: Full (283f48d8)

[mrserb]

I suggest to add logging here and rerun it many-many times to reproduce the bug to find out if the problem is in the wrong number of events or in the wrong extended state.

[alisenchung]

I've updated the test to include logging and ran the test 200x without failures. I think it's ok to push the test with these changes so that if the test ever does fail again we can use the logs and analyze the problem.

[mrserb]

I've updated the test to include logging and ran the test 200x without failures. I think it's ok to push the test with these changes so that if the test ever does fail again we can use the logs and analyze the problem.

I meant to run the test 200 times with logging but no other changes to find the root cause. The other changes to the test seems unnecessary at first glance. the test operations are already synchronized and delayed when necessary.

[alisenchung]

I've updated the test to include logging and ran the test 200x without failures. I think it's ok to push the test with these changes so that if the test ever does fail again we can use the logs and analyze the problem.

I meant to run the test 200 times with logging but no other changes to find the root cause. The other changes to the test seems unnecessary at first glance. the test operations are already synchronized and delayed when necessary.

I've reverted the test and added logging for the eventsCount. I've run the test thru mach5 again without failures 200x. For now adding logging to the test is probably sufficient for debugging if the failure happens again.

[TejeshR13]

If you are updating the test with debug print, then its better to do it as a sub task of main bug and retain the main bug as open until root cause is found.

[alisenchung]

/integrate

[openjdk]

Going to push as commit e91088a.
Since your change was applied there have been 408 commits pushed to the master branch:

• 75504a3: 8356588: Some nsk/jdi tests can fetch ThreadReference from static field in the debuggee: part 3
• 7c8e273: 8356420: Provide examples on wrapping System.in
• a262835: 8356641: Test com/sun/jdi/EarlyThreadGroupChildrenTest.java fails sometimes on macOS
• ... and 405 more: https://git.openjdk.org/jdk/compare/f98af0ad617a445362859e58af48258bfd5bed03...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alisenchung Pushed as commit e91088a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.