8355004: Apply java.io.Serial annotations in java.compiler

[mrserb]

Please review the application of @Serial annotation (JDK-8202385) to types in the compiler module to enable stricter compile-time checking of serialization-related declarations. Just a few classes are covered.

This annotation can be applied to these methods in the module:

private void writeObject(java.io.ObjectOutputStream stream) throws IOException
private void readObject(java.io.ObjectInputStream stream) throws IOException, ClassNotFoundException
private void readObjectNoData() throws ObjectStreamException
ANY-ACCESS-MODIFIER Object writeReplace() throws ObjectStreamException
ANY-ACCESS-MODIFIER Object readResolve() throws ObjectStreamException
private static final ObjectStreamField[] serialPersistentFields
private static final long serialVersionUID

Any feedback or suggestions are welcome!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8355004: Apply java.io.Serial annotations in java.compiler (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24891/head:pull/24891
$ git checkout pull/24891

Update a local copy of the PR:
$ git checkout pull/24891
$ git pull https://git.openjdk.org/jdk.git pull/24891/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24891

View PR using the GUI difftool:
$ git pr show -t 24891

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24891.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (af94d056)

[liach]

Hmm, was there no compiler warning from the lack of serial annotations?

[mrserb]

Hmm, was there no compiler warning from the lack of serial annotations?

There is no compiler warning currently, even with -Xlint:serial.