Skip to content

Add final & sealed to jdk.internal.reflect #24900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

wenshao
Copy link
Contributor

@wenshao wenshao commented Apr 26, 2025

I have discussed with @liach that we can improve the code of jdk.internal by adding final and sealed.

I will submit a series of PRs to do this, and this is one of them, jdk.internal.reflect

Adding final allows JIT to do more optimization and remove virtual function calls. Adding sealed makes the inheritance system clearer, and JIT may also make optimizations in the future.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24900/head:pull/24900
$ git checkout pull/24900

Update a local copy of the PR:
$ git checkout pull/24900
$ git pull https://git.openjdk.org/jdk.git pull/24900/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24900

View PR using the GUI difftool:
$ git pr show -t 24900

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24900.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 26, 2025

👋 Welcome back swen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 26, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Apr 26, 2025

@wenshao The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@wenshao
Copy link
Contributor Author

wenshao commented Apr 26, 2025

/label remove hotspot-runtime

@openjdk
Copy link

openjdk bot commented Apr 26, 2025

@wenshao
The hotspot-runtime label was successfully removed.

@wenshao wenshao closed this Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant