8359266: Delete the usage of AppContext in the GraphicsDevice #25818
+70
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the usage of AppContext from the GraphicsDevice class. The original use case was to store the full-screen window in some AppContext, which was necessary in the context of plugin/appletviewer environments. However, there is now effectively only one main AppContext, so this indirection can be eliminated.
Notes: GraphicsDevice provides two methods for handling full-screen windows:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25818/head:pull/25818
$ git checkout pull/25818
Update a local copy of the PR:
$ git checkout pull/25818
$ git pull https://git.openjdk.org/jdk.git pull/25818/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25818
View PR using the GUI difftool:
$ git pr show -t 25818
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25818.diff
Using Webrev
Link to Webrev Comment