Skip to content

8358129: compiler/startup/StartupOutput.java runs into out of memory on Windows after JDK-8347406 #25821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dafedafe
Copy link
Contributor

@dafedafe dafedafe commented Jun 16, 2025

Hi all,

This pull request contains a backport of commit 534a8605 from the openjdk/jdk repository.

The commit being backported was authored by Damon Fenacci on 16 Jun 2025 and was reviewed by Tobias Hartmann and Emanuel Peter.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358129: compiler/startup/StartupOutput.java runs into out of memory on Windows after JDK-8347406 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25821/head:pull/25821
$ git checkout pull/25821

Update a local copy of the PR:
$ git checkout pull/25821
$ git pull https://git.openjdk.org/jdk.git pull/25821/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25821

View PR using the GUI difftool:
$ git pr show -t 25821

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25821.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2025

👋 Welcome back dfenacci! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 16, 2025

@dafedafe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358129: compiler/startup/StartupOutput.java runs into out of memory on Windows after JDK-8347406

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the jdk25 branch:

  • 077ce2e: 8358764: (sc) SocketChannel.close when thread blocked in read causes connection to be reset (win)
  • 2a32945: 8359327: Incorrect AVX3Threshold results into code buffer overflows on APX targets

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk25 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 534a8605e5f4d771be69426687b2188d5353c91e 8358129: compiler/startup/StartupOutput.java runs into out of memory on Windows after JDK-8347406 Jun 16, 2025
@openjdk
Copy link

openjdk bot commented Jun 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 16, 2025

@dafedafe The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@dafedafe dafedafe marked this pull request as ready for review June 16, 2025 08:06
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 16, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 16, 2025
@dafedafe
Copy link
Contributor Author

Thanks for the review @shipilev.

@dafedafe
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 17, 2025

Going to push as commit cc4e971.
Since your change was applied there have been 9 commits pushed to the jdk25 branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 17, 2025
@openjdk openjdk bot closed this Jun 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 17, 2025
@openjdk
Copy link

openjdk bot commented Jun 17, 2025

@dafedafe Pushed as commit cc4e971.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants