Skip to content

8365264: Rename ResourceHashtable to HashTable #26729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

jdksjolen
Copy link
Contributor

@jdksjolen jdksjolen commented Aug 11, 2025

Hi,

This PR renames ResourceHashtable to HashTable. The "resource" part of the name isn't true anymore, it does many types of allocations. The RHT should be HT to signify that it's the default choice of hashtable in Hotspot.

I didn't change any copyright years for this change.

Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8365264: Rename ResourceHashtable to HashTable (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26729/head:pull/26729
$ git checkout pull/26729

Update a local copy of the PR:
$ git checkout pull/26729
$ git pull https://git.openjdk.org/jdk.git pull/26729/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26729

View PR using the GUI difftool:
$ git pr show -t 26729

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26729.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 11, 2025

👋 Welcome back jsjolen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 11, 2025

@jdksjolen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365264: Rename ResourceHashtable to HashTable

Reviewed-by: iklam, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 82 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8365264 8365264: Rename ResourceHashtable to HashTable Aug 11, 2025
@openjdk
Copy link

openjdk bot commented Aug 11, 2025

@jdksjolen The following labels will be automatically applied to this pull request:

  • graal
  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Aug 11, 2025

Webrevs

@jdksjolen
Copy link
Contributor Author

Aha, of course I forgot about re-sorting the headers.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 12, 2025
@iklam
Copy link
Member

iklam commented Aug 13, 2025

hashtable.hpp should become hashTable.hpp, which defines the type HashTable. (Existing example: concurrentHashTable.hpp defines the type ConcurrentHashTable).

resizeableResourceHash.hpp should be renamed to resizeableHashTable.hpp

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Aug 13, 2025
@jdksjolen
Copy link
Contributor Author

hashtable.hpp should become hashTable.hpp, which defines the type HashTable. (Existing example: concurrentHashTable.hpp defines the type ConcurrentHashTable).

resizeableResourceHash.hpp should be renamed to resizeableHashTable.hpp

Done!

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 13, 2025
@jdksjolen
Copy link
Contributor Author

Cheers!

/integrate

@openjdk
Copy link

openjdk bot commented Aug 13, 2025

Going to push as commit 4680dc9.
Since your change was applied there have been 85 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 13, 2025
@openjdk openjdk bot closed this Aug 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 13, 2025
@openjdk
Copy link

openjdk bot commented Aug 13, 2025

@jdksjolen Pushed as commit 4680dc9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants