Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8349974: [JMH,17u] MaskQueryOperationsBenchmark fails java.lang.NoClassDefFoundError #3277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 13, 2025

Hi all,

JMH tests org.openjdk.bench.jdk.incubator.vector.MaskQueryOperationsBenchmark report fails "java.lang.NoClassDefFoundError: jdk/incubator/vector/VectorSpecies" in jdk17u-dev repo.

This failure was fixed by JDK-8284960 in main-line repo, I think it's not suitable backport JDK-8284960 to jdk17u-dev. So I create this issue to fix failure.

Change has been verified locally, test-fix only, no risk.

Verify command:

build/linux-x86_64-server-release/images/jdk/bin/java -Djmh.ignoreLock=true -Djava.library.path=$PWD/build/linux-x86_64-server-release/images/test/micro/native --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED --add-opens=java.base/jdk.internal.misc=ALL-UNNAMED --add-opens java.base/sun.security.provider=ALL-UNNAMED --add-opens java.base/com.sun.crypto.provider=ALL-UNNAMED -jar $PWD/build/linux-x86_64-server-release/images/test/micro/benchmarks.jar -jvmArgsPrepend -Djava.library.path=$PWD/build/linux-x86_64-server-release/images/test/micro/native -t 1 -f 1 -wi 2 org.openjdk.bench.jdk.incubator.vector.MaskQueryOperationsBenchmark.testFirstTrueByte

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8349974 needs maintainer approval

Issue

  • JDK-8349974: [JMH,17u] MaskQueryOperationsBenchmark fails java.lang.NoClassDefFoundError (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3277/head:pull/3277
$ git checkout pull/3277

Update a local copy of the PR:
$ git checkout pull/3277
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3277/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3277

View PR using the GUI difftool:
$ git pr show -t 3277

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3277.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 13, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 13, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 13, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

Could anyone take look this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant