Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287801: Fix test-bugs related to stress flags #3290

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 21, 2025

Hi all,

This pull request contains a backport of commit 302a6c06 from the openjdk/jdk repository.

There are three files can not backport cleanly:

  1. Backport JDK-8271707 touch the file test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckSmearing.java cause this file can not backport cleanly.

  2. Below files not exists in jdk17u-dev cause JDK-8287801 can not backported cleanly.

test/hotspot/jtreg/compiler/uncommontrap/Decompile.java
test/hotspot/jtreg/compiler/rangechecks/TestLongRangeCheck.java

Backport to fix test bugs which cause tests fails with stress flags, make test more robustness, change has been verified locally, test-fix only, no risk.

Additional testing:

  • Run all the touch tests except test/hotspot/jtreg/compiler/c2/cr7200264/TestDriver.java on linux-aarch64
  • Run all the touch tests except test/hotspot/jtreg/compiler/c2/cr7200264/TestDriver.java on linux-x64

list.txt


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8287801 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287801: Fix test-bugs related to stress flags (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3290/head:pull/3290
$ git checkout pull/3290

Update a local copy of the PR:
$ git checkout pull/3290
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3290/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3290

View PR using the GUI difftool:
$ git pr show -t 3290

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3290.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287801: Fix test-bugs related to stress flags

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 116 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 302a6c068dcbb176381b1535baf25547079c9b06 8287801: Fix test-bugs related to stress flags Feb 21, 2025
@openjdk
Copy link

openjdk bot commented Feb 21, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 21, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 21, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

Hi, can anyone take look this PR.

@openjdk
Copy link

openjdk bot commented Mar 24, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@sendaoYan
Copy link
Member Author

@phohensee Thanks for the review and approved.

/approval request Backport to fix test bugs which cause tests fails with stress flags, make test more robustness, change has been verified locally, test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@sendaoYan
8287801: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants