-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8350540: [17u,11u] B8312065.java fails Network is unreachable #3293
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Hi @sensayan, why doesn't this apply to head and jdk21? |
Hi @GoeLin Test test/jdk/java/net/Socket/B8312065.java was add by JDK-8312065, and this test only added for jdk17u-dev and jdk11u-dev. |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi, can anyone take look this PR. |
|
Hi all,
Test test/jdk/java/net/Socket/B8312065.java fails on some machines. Test assume 192.168.255.255 is not in use, but on some machines linux command
ping 192.168.255.255
will report "ping: connect: Network is unreachable" failure, so this test will report "java.net.ConnectException: Network is unreachable (connect failed)" failure. And this failure is not caused by JDK bug, so I think it's better throwjtreg.SkippedException
when this failure reported.Change has been verified locally, test-fix only to make test more robustness, no risk.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3293/head:pull/3293
$ git checkout pull/3293
Update a local copy of the PR:
$ git checkout pull/3293
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3293/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3293
View PR using the GUI difftool:
$ git pr show -t 3293
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3293.diff
Using Webrev
Link to Webrev Comment