8350211: CTW: Attempt to preload all classes in constant pool

[satyenme]

Backporting JDK-8350211: CTW: Attempt to preload all classes in constant pool. Adjust CTW preloading to resolve all constant pool entries around exceptions. Ran GHA Sanity Checks, and local Tier 1, Tier 2 tests, and applications/ctw/modules tests (with fastdebug build). Patch is clean.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8350211 needs maintainer approval

Issue

• JDK-8350211: CTW: Attempt to preload all classes in constant pool (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3343/head:pull/3343
$ git checkout pull/3343

Update a local copy of the PR:
$ git checkout pull/3343
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3343/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3343

View PR using the GUI difftool:
$ git pr show -t 3343

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3343.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350211: CTW: Attempt to preload all classes in constant pool

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 96 new commits pushed to the master branch:

• 41b3541: 8298061: vmTestbase/nsk/sysdict/vm/stress/btree/btree012/btree012.java failed with "fatal error: refcount has gone to zero"
• 59468ba: 8349039: Adjust exception No type named in database
• 00c53b7: 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero
• 9631398: 8347576: Error output in libjsound has non matching format strings
• 96e8c56: 8277983: Remove unused fields from sun.net.www.protocol.jar.JarURLConnection
• 260f1c0: 8348107: test/jdk/java/net/httpclient/HttpsTunnelAuthTest.java fails intermittently
• 8cf4622: 8345134: Test sun/security/tools/jarsigner/ConciseJarsigner.java failed: unable to find valid certification path to requested target
• a064c2f: 8343529: serviceability/sa/ClhsdbWhere.java fails AssertionFailure: Corrupted constant pool
• 9a5b72f: 8341373: Open source closed frame tests # 4
• 5d02873: 8341000: Open source some of the AWT Window tests
• ... and 86 more: https://git.openjdk.org/jdk17u-dev/compare/6e37df10401b55a1944fb5c1007dea979f696e1c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (ba47babb)

[satyenme]

/approval request for backport. Adjust CTW preloading to resolve all constant pool entries, rather than stopping preloading after catching first exception. Ran GHA Sanity Checks, local Tier 1, Tier 2, and applications/ctw/modules tests (with fastdebug build) tests explicitly. Risk is low.

[openjdk]

@satyenme
8350211: The approval request has been created successfully.

[satyenme]

/integrate

[openjdk]

@satyenme
Your change (at version ba47bab) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 692f275.
Since your change was applied there have been 97 commits pushed to the master branch:

• 01425e4: 6956385: URLConnection.getLastModified() leaks file handles for jar:file and file: URLs
• 41b3541: 8298061: vmTestbase/nsk/sysdict/vm/stress/btree/btree012/btree012.java failed with "fatal error: refcount has gone to zero"
• 59468ba: 8349039: Adjust exception No type named in database
• 00c53b7: 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero
• 9631398: 8347576: Error output in libjsound has non matching format strings
• 96e8c56: 8277983: Remove unused fields from sun.net.www.protocol.jar.JarURLConnection
• 260f1c0: 8348107: test/jdk/java/net/httpclient/HttpsTunnelAuthTest.java fails intermittently
• 8cf4622: 8345134: Test sun/security/tools/jarsigner/ConciseJarsigner.java failed: unable to find valid certification path to requested target
• a064c2f: 8343529: serviceability/sa/ClhsdbWhere.java fails AssertionFailure: Corrupted constant pool
• 9a5b72f: 8341373: Open source closed frame tests # 4
• ... and 87 more: https://git.openjdk.org/jdk17u-dev/compare/6e37df10401b55a1944fb5c1007dea979f696e1c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @satyenme Pushed as commit 692f275.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.