8348107: test/jdk/java/net/httpclient/HttpsTunnelAuthTest.java fails intermittently

[GoeLin]

I backport this for parity with 17.0.16-oracle.

HttpClient does not implement AutoClosable in 17, so try-with-resources can not be used here.
This part of the fix is only cleanup, so we can get along without it.
I tried to keep the formatting of the code as close to 21 as possible.

https://bugs.openjdk.org/browse/JDK-8267140 Support closing the HttpClient by making it auto-closable
came only in 21.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8348107 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8348107: test/jdk/java/net/httpclient/HttpsTunnelAuthTest.java fails intermittently (Bug - P4 - Approved)

Reviewers

• Ralf Schmelter (@schmelter-sap - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3372/head:pull/3372
$ git checkout pull/3372

Update a local copy of the PR:
$ git checkout pull/3372
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3372/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3372

View PR using the GUI difftool:
$ git pr show -t 3372

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3372.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348107: test/jdk/java/net/httpclient/HttpsTunnelAuthTest.java fails intermittently

Reviewed-by: rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• b2255b9: 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing
• 4e67796: 8303770: Remove Baltimore root certificate expiring in May 2025
• 763ee0a: 8348110: Update LCMS to 2.17
• dda39ec: 8280991: [XWayland] No displayChanged event after setDisplayMode call
• e31723b: 8345598: Upgrade NSS binaries for interop tests
• 3a0e19b: 8350260: Improve HTML instruction formatting in PassFailJFrame
• 3d76ae0: 8294155: Exception thrown before awaitAndCheck hangs PassFailJFrame
• 011a970: 8342524: Use latch in AbstractButton/bug6298940.java instead of delay
• 5fdaafb: 8343936: Adjust timeout in test javax/management/monitor/DerivedGaugeMonitorTest.java
• d0a02d0: 8343103: Enable debug logging for vmTestbase/nsk/jvmti/scenarios/sampling/SP05/sp05t003/TestDescription.java
• ... and 18 more: https://git.openjdk.org/jdk17u-dev/compare/fd50c1722380ce419bd5ac7f1318d1a808f87ec5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (96dee4c2)

[schmelter-sap]

Looks good.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 260f1c0.
Since your change was applied there have been 45 commits pushed to the master branch:

• 8cf4622: 8345134: Test sun/security/tools/jarsigner/ConciseJarsigner.java failed: unable to find valid certification path to requested target
• a064c2f: 8343529: serviceability/sa/ClhsdbWhere.java fails AssertionFailure: Corrupted constant pool
• 9a5b72f: 8341373: Open source closed frame tests # 4
• 5d02873: 8341000: Open source some of the AWT Window tests
• 90b1bdd: 8340228: Open source couple more miscellaneous AWT tests
• 65ff527: 8339906: Open source several AWT focus tests - series 4
• df6cdbe: 8339794: Open source closed choice tests 8278822: Bump update version for OpenJDK: jdk-17.0.3 #1
• 0bba486: 8337299: vmTestbase/nsk/jdb/stop_at/stop_at002/stop_at002.java failure goes undetected
• 8d513cf: 8316388: Opensource five Swing component related regression tests
• e4cbb3b: 8315981: Opensource five more random Swing tests
• ... and 35 more: https://git.openjdk.org/jdk17u-dev/compare/fd50c1722380ce419bd5ac7f1318d1a808f87ec5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 260f1c0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.