Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337299: vmTestbase/nsk/jdb/stop_at/stop_at002/stop_at002.java failure goes undetected #3392

Closed
wants to merge 1 commit into from
Closed

8337299: vmTestbase/nsk/jdb/stop_at/stop_at002/stop_at002.java failure goes undetected #3392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 47 additions & 17 deletions test/hotspot/jtreg/vmTestbase/nsk/jdb/stop_at/stop_at002/stop_at002.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2002, 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2002, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -82,17 +82,10 @@ public static int run(String argv[], PrintStream out) {
static final String DEBUGGEE_CLASS = TEST_CLASS + "a";
static final String FIRST_BREAK = DEBUGGEE_CLASS + ".main";
static final String LAST_BREAK = DEBUGGEE_CLASS + ".lastBreak";
static final String DEBUGGEE_LOCATION1 = DEBUGGEE_CLASS + "$Nested$DeeperNested$DeepestNested:43";
static final String DEBUGGEE_LOCATION2 = DEBUGGEE_CLASS + "$Inner$MoreInner:57";
static final String FAILURE_PATTERN = "Unable to set";
static final String DEBUGGEE_LOCATION1 = DEBUGGEE_CLASS + "$Nested$DeeperNested$DeepestNested:64";
static final String DEBUGGEE_LOCATION2 = DEBUGGEE_CLASS + "$Inner$MoreInner:78";

protected void runCases() {
String[] reply;
Paragrep grep;
int count;
Vector v;
String found;

if (!checkStop(DEBUGGEE_LOCATION1)) {
success = false;
}
Expand All @@ -101,25 +94,62 @@ protected void runCases() {
success = false;
}

jdb.contToExit(3);
if (!checkBreakpointHit(DEBUGGEE_LOCATION1)) {
success = false;
}

if (!checkBreakpointHit(DEBUGGEE_LOCATION2)) {
success = false;
}

jdb.contToExit(1);
}

private boolean checkStop (String location) {
private boolean checkStop(String location) {
Paragrep grep;
String[] reply;
String found;
boolean result = true;

log.display("Trying to set breakpoint at line: " + location);
reply = jdb.receiveReplyFor(JdbCommand.stop_at + location);

grep = new Paragrep(reply);
found = grep.findFirst(FAILURE_PATTERN);
found = grep.findFirst("Deferring breakpoint " + location);
if (found.length() == 0) {
log.complain("jdb failed to setup deferred breakpoint at line: " + location);
return false;
}

return true;
}

private boolean checkBreakpointHit(String location) {
Paragrep grep;
String[] reply;
String found;

log.display("continuing to breakpoint at line: " + location);
reply = jdb.receiveReplyFor(JdbCommand.cont);
grep = new Paragrep(reply);

found = grep.findFirst("Unable to set deferred breakpoint");
if (found.length() > 0) {
log.complain("jdb failed to set line breakpoint at line: " + found);
result = false;
log.complain("jdb failed to set deferred breakpoint at line: " + location);
return false;
}

found = grep.findFirst("Set deferred breakpoint " + location);
if (found.length() == 0) {
log.complain("jdb failed to set deferred breakpoint at line: " + location);
return false;
}

found = grep.findFirst("Breakpoint hit: \"thread=main\", ");
if (found.length() == 0) {
log.complain("jdb failed to hit breakpoint at line: " + location);
return false;
}

return result;
return true;
}
}
8 changes: 5 additions & 3 deletions test/hotspot/jtreg/vmTestbase/nsk/jdb/stop_at/stop_at002/stop_at002a.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2002, 2018, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2002, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand All @@ -21,6 +21,8 @@
* questions.
*/

// THIS TEST IS LINE NUMBER SENSITIVE

package nsk.jdb.stop_at.stop_at002;

import nsk.share.*;
Expand Down Expand Up @@ -59,7 +61,7 @@ class Nested {
class DeeperNested {
class DeepestNested {
public void foo(boolean input) {
flag = input; /* <-------- This is line number 43 */
flag = input; /* <-------- This is line number 64 */
}
}
}
Expand All @@ -73,7 +75,7 @@ public MoreInner() {
content = "";
}
public void foo(String input) {
content += input; /* <-------- This is line number 57 */
content += input; /* <-------- This is line number 78 */
}
}
}
Expand Down