-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Index overshoot #1413
[Fix] Index overshoot #1413
Conversation
/assign @zmberg |
Signed-off-by: 刘硕 <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ls-2018 Shouldn't the user be allowed to configure KRUISE_CONTAINER_BARRIER themselves, and if they do, it should be overridden by the kruise webhook? |
@zmberg I don't think we need to expose this to the user. The user just needs to operate KRUISE_CONTAINER_PRIORITY. If the user sets KRUISE_CONTAINER_BARRIER, I personally feel that it is better to override the env, after all, this is a very special. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@ls-2018: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1413 +/- ##
==========================================
+ Coverage 48.23% 48.45% +0.21%
==========================================
Files 153 157 +4
Lines 21492 22724 +1232
==========================================
+ Hits 10367 11010 +643
- Misses 9985 10545 +560
- Partials 1140 1169 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
When I try to manually specify a key in configmap, the controller panics