-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "fix deleteAvailableLimit bug (#1481)" #1487
Conversation
This fix is incorrect. This reverts commit f4e238f. Signed-off-by: liheng.zms <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1487 +/- ##
==========================================
+ Coverage 47.94% 48.58% +0.64%
==========================================
Files 157 157
Lines 22432 22480 +48
==========================================
+ Hits 10754 10921 +167
+ Misses 10487 10356 -131
- Partials 1191 1203 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: liheng.zms <[email protected]>
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
) * Revert "fix deleteAvailableLimit bug (openkruise#1481)" This fix is incorrect. This reverts commit f4e238f. * add cloneset scale ut ---------
Could you please explain why should we keep to use deleteReadyLimit rather than deleteAvailableLimit despite that deleteReadyLimit is calculated from maxUnavailable and totalUnavailable |
This fix is incorrect.
This reverts commit f4e238f.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews