Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix deleteAvailableLimit bug (#1481)" #1487

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Jan 11, 2024

This fix is incorrect.

This reverts commit f4e238f.

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

This fix is incorrect.

This reverts commit f4e238f.

Signed-off-by: liheng.zms <[email protected]>
@kruise-bot kruise-bot added the size/L size/L: 100-499 label Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6f1b1d4) 47.94% compared to head (1597112) 48.58%.
Report is 3 commits behind head on master.

Files Patch % Lines
pkg/controller/cloneset/sync/cloneset_scale.go 50.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1487      +/-   ##
==========================================
+ Coverage   47.94%   48.58%   +0.64%     
==========================================
  Files         157      157              
  Lines       22432    22480      +48     
==========================================
+ Hits        10754    10921     +167     
+ Misses      10487    10356     -131     
- Partials     1191     1203      +12     
Flag Coverage Δ
unittests 48.58% <63.63%> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: liheng.zms <[email protected]>
@kruise-bot kruise-bot added size/M size/M: 30-99 and removed size/L size/L: 100-499 labels Jan 23, 2024
@FillZpp
Copy link
Member

FillZpp commented Jan 24, 2024

/lgtm

@zmberg
Copy link
Member Author

zmberg commented Jan 24, 2024

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 19854e8 into openkruise:master Jan 24, 2024
27 checks passed
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
)

* Revert "fix deleteAvailableLimit bug (openkruise#1481)"

This fix is incorrect.

This reverts commit f4e238f.


* add cloneset scale ut


---------
@huaouo
Copy link

huaouo commented Nov 29, 2024

Could you please explain why should we keep to use deleteReadyLimit rather than deleteAvailableLimit despite that deleteReadyLimit is calculated from maxUnavailable and totalUnavailable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants