Feature: SidecarSet injection supports Partial strategy #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AiRanthem <[email protected]>
|
@furykerry please help me to name the TODOSidecarSetInjectRevisionPolicy |
Signed-off-by: AiRanthem <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1856 +/- ##
==========================================
+ Coverage 47.91% 50.05% +2.13%
==========================================
Files 162 192 +30
Lines 23491 24717 +1226
==========================================
+ Hits 11256 12372 +1116
- Misses 11014 11071 +57
- Partials 1221 1274 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: AiRanthem <[email protected]>
AiRanthem
changed the title
AiRanthem
changed the title
furykerry
reviewed
Dec 16, 2024
Signed-off-by: AiRanthem <[email protected]>
Signed-off-by: AiRanthem <[email protected]>
|
/lgtm |
furykerry
pushed a commit
to furykerry/kruise
that referenced
this pull request
Feb 8, 2025
) * SidecarSet injection supports TODO strategy Signed-off-by: AiRanthem <[email protected]> * passing test Signed-off-by: AiRanthem <[email protected]> * rename the policy Signed-off-by: AiRanthem <[email protected]> * Partition and Selector cannot be used together Signed-off-by: AiRanthem <[email protected]> * Partition and Selector cannot be used together Signed-off-by: AiRanthem <[email protected]> --------- Signed-off-by: AiRanthem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Now, SidecarSet supports two policies in
injectionStrategy:Always, which is the default and current policy. Under this policy, all newly created Pods will be injected with the specified revision ininjectionStrategy.Partial, under which only when the Pod is not selected by the Selector explicitly configured inUpdateStrategywill it be definitely injected with the specified revision. In all other conditions, newly created Pods have a probability of being injected with the latest Sidecar, where the probability is1 - UpdateStrategy.Partition. IfPartitionis not a percentage or is not configured, its value is considered to be 0%.Ⅱ. Does this pull request fix one issue?
fixes #1833
Ⅲ. Describe how to verify it
see the unit tests added
Ⅳ. Special notes for reviews