recreate pod when qos changed #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1866 +/- ##
==========================================
+ Coverage 47.91% 50.31% +2.39%
==========================================
Files 162 193 +31
Lines 23491 24891 +1400
==========================================
+ Hits 11256 12523 +1267
- Misses 11014 11079 +65
- Partials 1221 1289 +68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
furykerry
reviewed
Dec 20, 2024
furykerry
reviewed
Dec 23, 2024
| Spec: *oldTemp.Spec.DeepCopy(), | ||
| } | ||
| newPod := &v1.Pod{ | ||
| Spec: *newTemp.Spec.DeepCopy(), |
There was a problem hiding this comment.
is deepcopy really necessary?
Signed-off-by: Abner-1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
fixes #1212
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews