bump features to beta in 1.8 #1919
Open
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1919 +/- ##
==========================================
+ Coverage 42.45% 42.57% +0.12%
==========================================
Files 312 313 +1
Lines 31328 31364 +36
==========================================
+ Hits 13301 13354 +53
+ Misses 16657 16642 -15
+ Partials 1370 1368 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/lgtm |
furykerry
reviewed
Feb 12, 2025
pkg/features/kruise_features.go
Outdated
| ResourcesDeletionProtection: {Default: true, PreRelease: featuregate.Alpha}, | ||
| WorkloadSpread: {Default: true, PreRelease: featuregate.Alpha}, | ||
| PodUnavailableBudgetDeleteGate: {Default: true, PreRelease: featuregate.Alpha}, | ||
| ResourcesDeletionProtection: {Default: true, PreRelease: featuregate.Beta}, |
There was a problem hiding this comment.
ResourcesDeletionProtection is a beta feature, but it need hook the deletion of namespace/crd and built-in workloads, plz close the featuregate by default
Signed-off-by: Abner-1 <[email protected]>
ABNER-1
force-pushed
the
bump_features_to_beta_in_1.8
branch
from
02af5fe to
1abe0fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fixes #1904
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews