-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raytrace plots #2655
Open
gridley
wants to merge
59
commits into
openmc-dev:develop
Choose a base branch
from
gridley:raytrace_plots
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Raytrace plots #2655
Changes from 57 commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
f55def3
implement Phong-shaded ray trace plots
gridley 0cf377d
remove outdated TODO
gridley 94913e7
use std::set for opaque ids in plot
gridley 9752412
use doxygen class comments for new plot types
gridley ff94c9f
clang format
gridley 50dbc18
add application of inverse rotation method to Position class
gridley 923e293
review comments
gridley 8a014ad
get clang-format to pass
gridley afd408e
try to make clangformat happy
gridley 6282f04
update comment
gridley fb352d0
nominal fixes for ray trace plots with dagmc
gridley 2f85fb9
have ray-based plotting use seperate in-model and out-model loops
gridley 1e28719
remove extraneous passing of particle state to reflections
gridley 4f19579
now works beautifully with dagmc
gridley fa8bed6
Merge remote-tracking branch 'upstream/develop' into raytrace_plots
pshriwise ab5480d
Providing rng. Correcting comment indentation
pshriwise d5d04fb
Updating plot_projection results. Verified that there are no noticeab…
pshriwise b6bad23
fix comment indentation in plots.py
gridley c536898
address review comments
gridley 79614ed
Reverting to old Surface::reflect signatures
pshriwise c24e37a
C++ style
pshriwise 61fdaed
Adding XML roundtrip test for PhongPlot
pshriwise 0ae7612
Adding methods operating on the camera class for clarity. Templating …
pshriwise 9fbf479
Correct test name
pshriwise 8989eb7
Simplifying logic in Plots.from_xml_element
pshriwise 027deee
Passing particle pointer to Surface::reflect, re-adding Ensures in DA…
pshriwise 7c8f988
Correcting comment indentation
pshriwise d76ffe5
Test PhongPlot repr
pshriwise b202ee5
Style update
pshriwise 90012e5
Adding description of the camera_to_model matrix axes
pshriwise 58cce6d
Adding tests for ProjectionPlot roundtrip
pshriwise d4ed3de
Style update
pshriwise 6280602
rm whitespace
pshriwise 6cc4d1a
Using some existing data members on GeometryState when possible
pshriwise 4593775
Starting a refactor
pshriwise ad47cdf
Using new method. No visual changes but some small ones.
pshriwise c674b4d
Move std::abs out of adv_to_bnd_frm_vd
pshriwise 7cdf555
Turn i_surface_ into a token
pshriwise 2920938
Change from index check to token check
pshriwise 6779f55
Better evaluation of surface normal
pshriwise cb8ebf9
Getting rid of i_surface_ attribute in favor of built-in surface toke…
pshriwise 3228f8b
Removing first_surface_ attribute in favor of a local variable in tra…
pshriwise 51b9412
Removing intersection_found_ member variable
pshriwise 189828d
Removing intersection found variable altogether
pshriwise 2a84266
Removing first_surface variable altogether
pshriwise c490367
whitespace
pshriwise 36ac7cf
Style
pshriwise 818418a
Updating projection plot results again
pshriwise 22fced2
Removing unused method from RayTracePlot
pshriwise 1da7b93
Merge remote-tracking branch 'upstream/develop' into raytrace_plots
pshriwise ba7db72
Updating to Surface::geom_type accessor
pshriwise a889387
Style
pshriwise 5f01059
Style again
pshriwise 782fc13
Merge remote-tracking branch 'upstream/develop' into raytrace_plots
pshriwise 313df06
Updates based on changes in #3260
pshriwise 05d6dc4
Moving to surface indices for identifier in TrackSegment.
pshriwise d87ba96
Very minor cleanup in plots.py
pshriwise ada075a
Consistent spacing in rst files
paulromano 2afaefc
Small edits here and there
paulromano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this file is missing