(feat) O3-4013: Add support for partial (estimated) dates #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -92.1 kB (-1.36%) Total Size: 6.67 MB
ℹ️ View Unchanged
|
donaldkibet
reviewed
Feb 12, 2025
This leverages the any-date-parser library to parse partial date representations. Note that there are some serious edge cases with estimated birth dates less than a day old, but hopefully that's not something we need to deal with.
Co-authored-by: Donald Kibet <[email protected]>
NethmiRodrigo
force-pushed
the
feat/support-partial-dates-in-age
branch
from
e8b407b to
74e0c2a
Compare
|
So one of the failing e2e tests are expected "e2e/specs/register-new-patient.spec.ts:87:5 › Register an unknown patient › And I should see the newly registered patient's details displayed in the patient banner" where its expecting to see a full birthdate by searching for "01-Jan-2000" which this PR changes to just "2000". So we'll need to update the e2e test itself on patient-management once this goes in. |
|
The other failing test (is for one very badly written), which tests managing patient lists fails because it tries to test the deletion of a patient from a list (expect it does so by directly calling the API in the test - https://github.com/openmrs/openmrs-esm-patient-management/blob/9201ed389bd8f811ff2c1f265c4ccbf60d5c3079/e2e/specs/patient-list.spec.ts#L84 instead of interacting the UI (as an e2e test should). Anyways the API call apparently fails weirdly which is why the test fails. CC @denniskigen |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This should resolve O3-4013. In essence, for estimated birthdates, the FHIR API returns only a partial date. DayJS interpolates this with (essentially) the "zero value" for each field, so, e.g., the FHIR string "2014" (representing "born sometime in 2014") gets interpreted as "2014-01-01", etc. which leads to screens that looks incorrect.
Because I was lazy, this uses the
any-date-parsereven though we don't actually need most of it's features. However, it was the only date parser I could find that would return a partial object instead of trying to construct a date (at least without hacking into non-public APIs). Eventually, we may want to replace this with something lighter-weight.Screenshots
Related Issue
Other
I'm not entirely sure the changes to
age()are necessary.Note that there are some serious edge cases with estimated birth dates less than a day old, but hopefully that's not something we need to deal with.