-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-4400 - add a way to identify where the patient banner is be… #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing rendered from
Size Change: -88.4 kB (-1.4%) Total Size: 6.21 MB
ℹ️ View Unchanged
|
mogoodrich
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defer to others, but generally LGTM, thanks @chibongho !
samuelmale
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing rendered from
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
As part of the work to remove the custom Visit Header from the patient chart, we need to move the queue entry status indicator and edit link from the visit header into the patient banner within the patient chart. We want to implement the queue entry status indicator as an extension from the queues app to be slotted into the patient banner. However, the patient banner is used not only in patient chart, but also other places like search results,. This PR adds an extra prop to the patient banner patient info, so that extensions within it can know where the banner is rendered from and behave accordingly.
(Screenshot for illustration, not part of this PR).

Current Queue entry status indicator:
Desired:

Screenshots
Related Issue
Other