Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) O3-4362: Move Location Picker to the top nav #1295

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

(feat) O3-4362: Move Location Picker to the top nav #1295

wants to merge 2 commits into from
+41 −19

Conversation

chibongho
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

This PR adds the Location Picker directly onto the top nav, and removes it from the top-right user menu. Based on mockup here.

Minor deviations from mockup:

  • In the mockup, the font size of the "OpenMRS" logo text and the Location are both ~12px. I made the location font size = 14px to better match the font size of the "OpenMRS" logo text
  • margins / paddings are rounded to the nearest $layout.spacingXX size.

Screenshots

ltr, desktop:
image

ltr, mobile:
image

rtl, desktop:
image

rtl, mobile:
image

Related Issue

https://openmrs.atlassian.net/browse/O3-4362

Other

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 24, 2025 •
edited
Loading

Size Change: +981 B (+0.02%)

Total Size: 6.21 MB

ℹ️ View Unchanged
Filename Size Change
packages/apps/esm-devtools-app/dist/373.js 12 kB 0 B
packages/apps/esm-devtools-app/dist/593.js 149 kB 0 B
packages/apps/esm-devtools-app/dist/642.js 21.1 kB 0 B
packages/apps/esm-devtools-app/dist/647.js 2.32 kB 0 B
packages/apps/esm-devtools-app/dist/657.js 7.02 kB 0 B
packages/apps/esm-devtools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-devtools-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-devtools-app/dist/889.js 376 kB 0 B
packages/apps/esm-devtools-app/dist/988.js 325 B 0 B
packages/apps/esm-devtools-app/dist/main.js 3.22 kB 0 B
packages/apps/esm-devtools-app/dist/openmrs-esm-devtools-app.js 3.28 kB 0 B
packages/apps/esm-help-menu-app/dist/248.js 10.2 kB 0 B
packages/apps/esm-help-menu-app/dist/474.js 705 B 0 B
packages/apps/esm-help-menu-app/dist/611.js 2.45 kB 0 B
packages/apps/esm-help-menu-app/dist/642.js 21.1 kB 0 B
packages/apps/esm-help-menu-app/dist/657.js 7.02 kB 0 B
packages/apps/esm-help-menu-app/dist/662.js 147 kB 0 B
packages/apps/esm-help-menu-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-help-menu-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-help-menu-app/dist/889.js 376 kB 0 B
packages/apps/esm-help-menu-app/dist/958.js 3.73 kB 0 B
packages/apps/esm-help-menu-app/dist/main.js 8.56 kB 0 B
packages/apps/esm-help-menu-app/dist/openmrs-esm-help-menu-app.js 3.23 kB 0 B
packages/apps/esm-implementer-tools-app/dist/1491.js 134 kB 0 B
packages/apps/esm-implementer-tools-app/dist/1644.js 758 B 0 B
packages/apps/esm-implementer-tools-app/dist/1873.js 3.67 kB 0 B
packages/apps/esm-implementer-tools-app/dist/1901.js 590 B 0 B
packages/apps/esm-implementer-tools-app/dist/2016.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/236.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/2735.js 2.63 kB 0 B
packages/apps/esm-implementer-tools-app/dist/2757.js 714 B 0 B
packages/apps/esm-implementer-tools-app/dist/2788.js 42.9 kB 0 B
packages/apps/esm-implementer-tools-app/dist/3336.js 137 kB 0 B
packages/apps/esm-implementer-tools-app/dist/3448.js 4.66 kB 0 B
packages/apps/esm-implementer-tools-app/dist/3574.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/3652.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/4272.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/4378.js 699 B 0 B
packages/apps/esm-implementer-tools-app/dist/4426.js 27.8 kB 0 B
packages/apps/esm-implementer-tools-app/dist/4460.js 786 B 0 B
packages/apps/esm-implementer-tools-app/dist/4705.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/4889.js 376 kB 0 B
packages/apps/esm-implementer-tools-app/dist/5240.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/5336.js 591 B 0 B
packages/apps/esm-implementer-tools-app/dist/539.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/5642.js 21.1 kB 0 B
packages/apps/esm-implementer-tools-app/dist/5673.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/5711.js 671 B 0 B
packages/apps/esm-implementer-tools-app/dist/5737.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/5833.js 727 B 0 B
packages/apps/esm-implementer-tools-app/dist/587.js 2.93 kB 0 B
packages/apps/esm-implementer-tools-app/dist/5962.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/6497.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/6566.js 700 B 0 B
packages/apps/esm-implementer-tools-app/dist/667.js 121 kB 0 B
packages/apps/esm-implementer-tools-app/dist/6727.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/7036.js 2.5 kB 0 B
packages/apps/esm-implementer-tools-app/dist/744.js 722 B 0 B
packages/apps/esm-implementer-tools-app/dist/7807.js 591 B 0 B
packages/apps/esm-implementer-tools-app/dist/7859.js 3.09 kB 0 B
packages/apps/esm-implementer-tools-app/dist/8271.js 753 B 0 B
packages/apps/esm-implementer-tools-app/dist/8289.js 14.3 kB 0 B
packages/apps/esm-implementer-tools-app/dist/8319.js 687 B 0 B
packages/apps/esm-implementer-tools-app/dist/8323.js 591 B 0 B
packages/apps/esm-implementer-tools-app/dist/845.js 6.43 kB 0 B
packages/apps/esm-implementer-tools-app/dist/8657.js 7.02 kB 0 B
packages/apps/esm-implementer-tools-app/dist/8788.js 590 B 0 B
packages/apps/esm-implementer-tools-app/dist/899.js 590 B 0 B
packages/apps/esm-implementer-tools-app/dist/9261.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/9441.js 4.38 kB 0 B
packages/apps/esm-implementer-tools-app/dist/9579.js 591 B 0 B
packages/apps/esm-implementer-tools-app/dist/main.js 21 kB 0 B
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js 3.4 kB 0 B
packages/apps/esm-login-app/dist/1644.js 934 B 0 B
packages/apps/esm-login-app/dist/1676.js 2.23 kB 0 B
packages/apps/esm-login-app/dist/1901.js 751 B 0 B
packages/apps/esm-login-app/dist/2016.js 752 B 0 B
packages/apps/esm-login-app/dist/236.js 777 B 0 B
packages/apps/esm-login-app/dist/2735.js 2.62 kB 0 B
packages/apps/esm-login-app/dist/2757.js 920 B 0 B
packages/apps/esm-login-app/dist/2788.js 42.9 kB 0 B
packages/apps/esm-login-app/dist/3574.js 759 B +7 B (+0.93%)
packages/apps/esm-login-app/dist/3593.js 149 kB 0 B
packages/apps/esm-login-app/dist/3652.js 752 B 0 B
packages/apps/esm-login-app/dist/415.js 26.7 kB 0 B
packages/apps/esm-login-app/dist/4272.js 761 B 0 B
packages/apps/esm-login-app/dist/4378.js 878 B 0 B
packages/apps/esm-login-app/dist/4460.js 990 B 0 B
packages/apps/esm-login-app/dist/4705.js 752 B 0 B
packages/apps/esm-login-app/dist/4889.js 376 kB 0 B
packages/apps/esm-login-app/dist/5211.js 35.4 kB +382 B (+1.09%)
packages/apps/esm-login-app/dist/5240.js 841 B 0 B
packages/apps/esm-login-app/dist/5336.js 837 B 0 B
packages/apps/esm-login-app/dist/539.js 783 B 0 B
packages/apps/esm-login-app/dist/5642.js 21.1 kB 0 B
packages/apps/esm-login-app/dist/5673.js 791 B 0 B
packages/apps/esm-login-app/dist/5711.js 876 B 0 B
packages/apps/esm-login-app/dist/5737.js 751 B 0 B
packages/apps/esm-login-app/dist/5833.js 888 B 0 B
packages/apps/esm-login-app/dist/5962.js 752 B 0 B
packages/apps/esm-login-app/dist/6202.js 2.57 kB 0 B
packages/apps/esm-login-app/dist/6497.js 751 B 0 B
packages/apps/esm-login-app/dist/6566.js 906 B 0 B
packages/apps/esm-login-app/dist/6727.js 752 B 0 B
packages/apps/esm-login-app/dist/7.js 3.03 kB 0 B
packages/apps/esm-login-app/dist/7063.js 16.5 kB 0 B
packages/apps/esm-login-app/dist/744.js 1.01 kB 0 B
packages/apps/esm-login-app/dist/7807.js 1.05 kB 0 B
packages/apps/esm-login-app/dist/7859.js 3.08 kB 0 B
packages/apps/esm-login-app/dist/8271.js 935 B 0 B
packages/apps/esm-login-app/dist/8319.js 867 B 0 B
packages/apps/esm-login-app/dist/8323.js 1.12 kB 0 B
packages/apps/esm-login-app/dist/8657.js 7.01 kB 0 B
packages/apps/esm-login-app/dist/8788.js 750 B 0 B
packages/apps/esm-login-app/dist/899.js 750 B 0 B
packages/apps/esm-login-app/dist/9261.js 752 B 0 B
packages/apps/esm-login-app/dist/93.js 2.16 kB 0 B
packages/apps/esm-login-app/dist/9579.js 751 B 0 B
packages/apps/esm-login-app/dist/9755.js 3.36 kB 0 B
packages/apps/esm-login-app/dist/main.js 63.5 kB +384 B (+0.61%)
packages/apps/esm-login-app/dist/openmrs-esm-login-app.js 3.46 kB 0 B
packages/apps/esm-offline-tools-app/dist/16.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/236.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/240.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/261.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/271.js 1.19 kB 0 B
packages/apps/esm-offline-tools-app/dist/272.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/319.js 1.16 kB 0 B
packages/apps/esm-offline-tools-app/dist/323.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/336.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/378.js 1.17 kB 0 B
packages/apps/esm-offline-tools-app/dist/460.js 1.3 kB 0 B
packages/apps/esm-offline-tools-app/dist/497.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/539.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/566.js 1.17 kB 0 B
packages/apps/esm-offline-tools-app/dist/574.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/579.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/601.js 142 kB 0 B
packages/apps/esm-offline-tools-app/dist/625.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/63.js 16.5 kB 0 B
packages/apps/esm-offline-tools-app/dist/642.js 21.1 kB 0 B
packages/apps/esm-offline-tools-app/dist/644.js 1.19 kB 0 B
packages/apps/esm-offline-tools-app/dist/645.js 91.6 kB 0 B
packages/apps/esm-offline-tools-app/dist/652.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/657.js 7.02 kB 0 B
packages/apps/esm-offline-tools-app/dist/673.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/703.js 6.32 kB 0 B
packages/apps/esm-offline-tools-app/dist/705.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/711.js 1.16 kB 0 B
packages/apps/esm-offline-tools-app/dist/727.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-offline-tools-app/dist/737.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/744.js 1.28 kB 0 B
packages/apps/esm-offline-tools-app/dist/757.js 1.19 kB 0 B
packages/apps/esm-offline-tools-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-offline-tools-app/dist/807.js 1.1 kB 0 B
packages/apps/esm-offline-tools-app/dist/833.js 1.21 kB 0 B
packages/apps/esm-offline-tools-app/dist/859.js 3.09 kB 0 B
packages/apps/esm-offline-tools-app/dist/889.js 376 kB 0 B
packages/apps/esm-offline-tools-app/dist/899.js 1.02 kB 0 B
packages/apps/esm-offline-tools-app/dist/901.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/947.js 8.66 kB 0 B
packages/apps/esm-offline-tools-app/dist/962.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/main.js 107 kB 0 B
packages/apps/esm-offline-tools-app/dist/openmrs-esm-offline-tools-app.js 3.38 kB 0 B
packages/apps/esm-primary-navigation-app/dist/16.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/236.js 239 B 0 B
packages/apps/esm-primary-navigation-app/dist/238.js 146 kB 0 B
packages/apps/esm-primary-navigation-app/dist/240.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/261.js 241 B 0 B
packages/apps/esm-primary-navigation-app/dist/271.js 282 B 0 B
packages/apps/esm-primary-navigation-app/dist/272.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/319.js 246 B 0 B
packages/apps/esm-primary-navigation-app/dist/323.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/336.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/378.js 267 B 0 B
packages/apps/esm-primary-navigation-app/dist/379.js 4.22 kB 0 B
packages/apps/esm-primary-navigation-app/dist/460.js 277 B 0 B
packages/apps/esm-primary-navigation-app/dist/482.js 15.2 kB 0 B
packages/apps/esm-primary-navigation-app/dist/497.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/539.js 239 B 0 B
packages/apps/esm-primary-navigation-app/dist/566.js 262 B 0 B
packages/apps/esm-primary-navigation-app/dist/574.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/577.js 7.65 kB 0 B
packages/apps/esm-primary-navigation-app/dist/579.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/619.js 6.45 kB 0 B
packages/apps/esm-primary-navigation-app/dist/625.js 241 B 0 B
packages/apps/esm-primary-navigation-app/dist/63.js 16.5 kB 0 B
packages/apps/esm-primary-navigation-app/dist/644.js 290 B 0 B
packages/apps/esm-primary-navigation-app/dist/652.js 241 B 0 B
packages/apps/esm-primary-navigation-app/dist/657.js 7.03 kB 0 B
packages/apps/esm-primary-navigation-app/dist/673.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/705.js 241 B 0 B
packages/apps/esm-primary-navigation-app/dist/711.js 255 B 0 B
packages/apps/esm-primary-navigation-app/dist/727.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-primary-navigation-app/dist/737.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/744.js 288 B 0 B
packages/apps/esm-primary-navigation-app/dist/757.js 248 B 0 B
packages/apps/esm-primary-navigation-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-primary-navigation-app/dist/807.js 301 B 0 B
packages/apps/esm-primary-navigation-app/dist/833.js 282 B 0 B
packages/apps/esm-primary-navigation-app/dist/888.js 25.3 kB +104 B (+0.41%)
packages/apps/esm-primary-navigation-app/dist/889.js 376 kB 0 B
packages/apps/esm-primary-navigation-app/dist/899.js 237 B 0 B
packages/apps/esm-primary-navigation-app/dist/901.js 239 B 0 B
packages/apps/esm-primary-navigation-app/dist/962.js 241 B 0 B
packages/apps/esm-primary-navigation-app/dist/main.js 31.3 kB +104 B (+0.33%)
packages/apps/esm-primary-navigation-app/dist/openmrs-esm-primary-navigation-app.js 3.38 kB 0 B
packages/framework/esm-api/dist/openmrs-esm-api.js 16.9 kB 0 B
packages/framework/esm-config/dist/openmrs-esm-module-config.js 8.42 kB 0 B
packages/framework/esm-context/dist/openmrs-esm-context.js 1.16 kB 0 B
packages/framework/esm-dynamic-loading/dist/openmrs-esm-dynamic-loading.js 2.89 kB 0 B
packages/framework/esm-error-handling/dist/openmrs-esm-error-handling.js 891 B 0 B
packages/framework/esm-expression-evaluator/dist/openmrs-esm-expression-evaluator.js 9.02 kB 0 B
packages/framework/esm-extensions/dist/openmrs-esm-extensions.js 25.5 kB 0 B
packages/framework/esm-feature-flags/dist/openmrs-esm-feature-flags.js 1.66 kB 0 B
packages/framework/esm-framework/dist/278.openmrs-esm-framework.js 14.5 kB 0 B
packages/framework/esm-framework/dist/530.openmrs-esm-framework.js 2.93 kB 0 B
packages/framework/esm-framework/dist/588.openmrs-esm-framework.js 2.15 kB 0 B
packages/framework/esm-framework/dist/619.openmrs-esm-framework.js 6.49 kB 0 B
packages/framework/esm-framework/dist/645.openmrs-esm-framework.js 9.3 kB 0 B
packages/framework/esm-framework/dist/735.openmrs-esm-framework.js 2.65 kB 0 B
packages/framework/esm-framework/dist/746.openmrs-esm-framework.js 6.14 kB 0 B
packages/framework/esm-framework/dist/788.openmrs-esm-framework.js 42.9 kB 0 B
packages/framework/esm-framework/dist/openmrs-esm-framework.js 461 kB 0 B
packages/framework/esm-globals/dist/openmrs-esm-globals.js 791 B 0 B
packages/framework/esm-navigation/dist/openmrs-esm-navigation.js 9.34 kB 0 B
packages/framework/esm-offline/dist/openmrs-esm-offline.js 34.4 kB 0 B
packages/framework/esm-react-utils/dist/openmrs-esm-react-utils.js 21.9 kB 0 B
packages/framework/esm-routes/dist/openmrs-esm-utils.js 4.82 kB 0 B
packages/framework/esm-state/dist/openmrs-esm-state.js 1.59 kB 0 B
packages/framework/esm-styleguide/dist/openmrs-esm-styleguide.js 195 kB 0 B
packages/framework/esm-translations/dist/openmrs-esm-core-translations.js 1.92 kB 0 B
packages/framework/esm-utils/dist/openmrs-esm-utils.js 45.5 kB 0 B
packages/shell/esm-app-shell/dist/01001bd452edf96b.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/01b94747dec36fb0.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/2058b4ec98841572.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/2280106e69fcb6e7.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/2e9429d21af6e3ac.js 1.26 kB 0 B
packages/shell/esm-app-shell/dist/38d4b8fb75f8850c.js 18.3 kB 0 B
packages/shell/esm-app-shell/dist/3b01402cd7292844.js 2.85 kB 0 B
packages/shell/esm-app-shell/dist/3c905a475a09929a.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/3d59b015a911ce78.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/3f6dd2a036ca68a6.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/3f75953146d56a11.js 1.37 kB 0 B
packages/shell/esm-app-shell/dist/41ed5c5b03ca8e28.js 1.39 kB 0 B
packages/shell/esm-app-shell/dist/50c6bb7970c7a1b9.js 1.1 kB 0 B
packages/shell/esm-app-shell/dist/5112ac3a31bea2a7.js 48.7 kB 0 B
packages/shell/esm-app-shell/dist/528acd8ff95c0d83.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/55908a3f26b2a9a6.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/572e81f004cc10c5.js 15.1 kB 0 B
packages/shell/esm-app-shell/dist/5a68009041911dad.js 1.35 kB 0 B
packages/shell/esm-app-shell/dist/629c417e6764717f.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/65204f1dc81ae983.js 173 kB 0 B
packages/shell/esm-app-shell/dist/6f28b7b740beb889.js 1.35 kB 0 B
packages/shell/esm-app-shell/dist/6f47008d9c93c1cb.js 3.33 kB 0 B
packages/shell/esm-app-shell/dist/71ab27e0b8d1949e.js 2.58 kB 0 B
packages/shell/esm-app-shell/dist/788fdd707198d0b7.js 6.99 kB 0 B
packages/shell/esm-app-shell/dist/79e0fe636d1ed41c.js 1.59 kB 0 B
packages/shell/esm-app-shell/dist/7b204450699b0daf.js 2.6 kB 0 B
packages/shell/esm-app-shell/dist/88bf17e6e5c9acd0.js 6.38 kB 0 B
packages/shell/esm-app-shell/dist/8e0d11f862dfbba6.js 626 B 0 B
packages/shell/esm-app-shell/dist/a42a429e247a43fd.js 1.24 kB 0 B
packages/shell/esm-app-shell/dist/a7089447b7f2614b.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/a7792d6252d85b20.js 43 kB 0 B
packages/shell/esm-app-shell/dist/a7efa2596cd2be4f.js 168 kB 0 B
packages/shell/esm-app-shell/dist/b0c2799f84483ab9.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/b0f27b82b3231196.js 3.95 kB 0 B
packages/shell/esm-app-shell/dist/b407f548b6fadfa3.js 3.08 kB 0 B
packages/shell/esm-app-shell/dist/b44fb50339c45d13.js 1.25 kB 0 B
packages/shell/esm-app-shell/dist/b87a5878f8961d1a.js 2.23 kB 0 B
packages/shell/esm-app-shell/dist/b88532bde74b513a.js 9.41 kB 0 B
packages/shell/esm-app-shell/dist/bb04bb60f8aa150f.js 3.04 kB 0 B
packages/shell/esm-app-shell/dist/c6a19d9750c44512.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/c7abf1814f63a7d2.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/c7dc0c60e84d6e1e.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/cc0d293bb9b870d9.js 3.38 kB 0 B
packages/shell/esm-app-shell/dist/d6a680dea8be9922.js 1.24 kB 0 B
packages/shell/esm-app-shell/dist/d80464c66e5d20d7.js 3.23 kB 0 B
packages/shell/esm-app-shell/dist/defaa6411a461648.js 7.16 kB 0 B
packages/shell/esm-app-shell/dist/e2ec9aeac53221df.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/e419a658f4742c3e.js 9.36 kB 0 B
packages/shell/esm-app-shell/dist/eaa9326cc55c5139.js 66.8 kB 0 B
packages/shell/esm-app-shell/dist/eda7b495e8f8cf3a.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/f07d8d15ffe495b4.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/f09898631f52dc55.js 1.1 kB 0 B
packages/shell/esm-app-shell/dist/f157bed92d3f6fc7.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/f5c65190072bb3f7.js 626 B 0 B
packages/shell/esm-app-shell/dist/fb95c0d3b16066f3.js 1.22 kB 0 B
packages/shell/esm-app-shell/dist/fc6da4a7d41ed938.js 1.05 kB 0 B
packages/shell/esm-app-shell/dist/fcb385df17a82210.js 6.77 kB 0 B
packages/shell/esm-app-shell/dist/openmrs.415d3bdd95af05b0.js 21.8 kB 0 B
packages/shell/esm-app-shell/dist/service-worker.js 46.7 kB 0 B
packages/tooling/openmrs/dist/cli.js 2.84 kB 0 B
packages/tooling/openmrs/dist/commands/assemble.js 3.31 kB 0 B
packages/tooling/openmrs/dist/commands/build.js 1.34 kB 0 B
packages/tooling/openmrs/dist/commands/debug.js 543 B 0 B
packages/tooling/openmrs/dist/commands/develop.js 2.71 kB 0 B
packages/tooling/openmrs/dist/commands/index.js 437 B 0 B
packages/tooling/openmrs/dist/commands/start.js 850 B 0 B
packages/tooling/openmrs/dist/index.js 517 B 0 B
packages/tooling/openmrs/dist/runner.js 640 B 0 B
packages/tooling/openmrs/dist/utils/config.js 726 B 0 B
packages/tooling/openmrs/dist/utils/debugger.js 575 B 0 B
packages/tooling/openmrs/dist/utils/dependencies.js 643 B 0 B
packages/tooling/openmrs/dist/utils/helpers.js 397 B 0 B
packages/tooling/openmrs/dist/utils/importmap.js 3.21 kB 0 B
packages/tooling/openmrs/dist/utils/index.js 443 B 0 B
packages/tooling/openmrs/dist/utils/logger.js 368 B 0 B
packages/tooling/openmrs/dist/utils/npmConfig.js 831 B 0 B
packages/tooling/openmrs/dist/utils/untar.js 725 B 0 B
packages/tooling/openmrs/dist/utils/variables.js 192 B 0 B
packages/tooling/openmrs/dist/utils/webpack.js 278 B 0 B
packages/tooling/webpack-config/dist/index.js 3.61 kB 0 B

compressed-size-action

mogoodrich
mogoodrich approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@mogoodrich mogoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @chibongho !

denniskigen
denniskigen reviewed Feb 25, 2025
View reviewed changes
packages/apps/esm-primary-navigation-app/src/components/navbar/navbar.scss

.divider {
width: 1px;
height: 24px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
height: 24px;
height: layout.$spacing-06;

denniskigen
denniskigen approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nicely done, @chibongho!

@denniskigen denniskigen changed the title (feat) O3-4362 add Location Picker to the top nav (feat) O3-4362: Move Location Picker to the top nav Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mogoodrich mogoodrich mogoodrich approved these changes

@denniskigen denniskigen denniskigen approved these changes

@samuelmale samuelmale samuelmale approved these changes

@mseaton mseaton Awaiting requested review from mseaton

@vasharma05 vasharma05 Awaiting requested review from vasharma05

@ibacher ibacher Awaiting requested review from ibacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chibongho @mogoodrich @denniskigen @samuelmale