Skip to content

Node 8 support #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ehmicky opened this issue Oct 28, 2020 · 3 comments · Fixed by #41
Closed

Node 8 support #12

ehmicky opened this issue Oct 28, 2020 · 3 comments · Fixed by #41

Comments

@ehmicky
Copy link

ehmicky commented Oct 28, 2020

Our Node.js support is currently >=8.

This plugin is using fs.promises, which was introduced in Node 10. Using require('util').promisify(fs.appendFile) instead would make it work for Node 8 users.

Also, do you know whether next-on-netlify works on Node 8?

It'd be nice to add some engines.node like this. Our build system detects this property and prints a warning message when a site is using a Node.js version incompatible with a plugin.

Finally, our CI tests should run on Node 8 to ensure support.

@ehmicky ehmicky self-assigned this Nov 16, 2020
@ehmicky ehmicky changed the title Node 8.3.0 support Node 8 support Nov 16, 2020
@ehmicky ehmicky changed the title Node 8 support Node 8 support Nov 16, 2020
@ehmicky
Copy link
Author

ehmicky commented Nov 16, 2020

Next.js 9 only supports Node.js >=10.13.0:

https://github.com/vercel/next.js/blob/118ab7992bc8f7a7e5a7bb996510d9b56ffe4f68/package.json#L137

https://nextjs.org/docs/getting-started#system-requirements

So, unless we want to support Next.js 8, we will need to enable this plugin only if the build's Node.js version is >=10.13.0.

@ehmicky
Copy link
Author

ehmicky commented Nov 16, 2020

Since we only support Next.js >=9.5.3 (see #25), we can limit support for Node.js >=10.13.0.

@ehmicky
Copy link
Author

ehmicky commented Nov 16, 2020

Fixed by #41.

ascorbic pushed a commit that referenced this issue Oct 4, 2021
chore: use demo for tests instead of test/sample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant