-
Notifications
You must be signed in to change notification settings - Fork 86
Node 8 support #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Next.js https://github.com/vercel/next.js/blob/118ab7992bc8f7a7e5a7bb996510d9b56ffe4f68/package.json#L137 https://nextjs.org/docs/getting-started#system-requirements So, unless we want to support Next.js |
Since we only support Next.js |
Fixed by #41. |
chore: use demo for tests instead of test/sample
Our Node.js support is currently
>=8
.This plugin is using
fs.promises
, which was introduced in Node 10. Usingrequire('util').promisify(fs.appendFile)
instead would make it work for Node 8 users.Also, do you know whether
next-on-netlify
works on Node 8?It'd be nice to add some
engines.node
like this. Our build system detects this property and prints a warning message when a site is using a Node.js version incompatible with a plugin.Finally, our CI tests should run on Node 8 to ensure support.
The text was updated successfully, but these errors were encountered: