Skip to content

Fix support for Node 8 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix support for Node 8 #38

wants to merge 1 commit into from

Conversation

ehmicky
Copy link

@ehmicky ehmicky commented Nov 16, 2020

Fixes #12.

This adds tests for Node 8.
Jest has to be downgraded because the latest version does not support Node 8.
This seems to currently fail because next-on-netlify does not seem to support Node 8.

@ehmicky ehmicky added the type: bug code to address defects in shipped code label Nov 16, 2020
@ehmicky ehmicky self-assigned this Nov 16, 2020
@ehmicky
Copy link
Author

ehmicky commented Nov 16, 2020

Next.js 9 does not support Node 8. More information in #12 (comment)

@ehmicky
Copy link
Author

ehmicky commented Nov 16, 2020

Closing since we only need to support Node 10.13.0.

@ehmicky ehmicky closed this Nov 16, 2020
@ehmicky ehmicky deleted the bug/node-8 branch November 16, 2020 21:09
ascorbic pushed a commit that referenced this pull request Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node 8 support
1 participant