Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unstableNetlifyFunctionsSupport.includeDirs configuration #182
feat: unstableNetlifyFunctionsSupport.includeDirs configuration #182
Changes from all commits
8286365
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: we might want to remove the
mtime
when creating the archive.Otherwise, every zip archive of the same Function will have a different checksum. This has created some issues in the past which ended up increasing our AWS Lambda usage weekly rate significantly.
See https://github.com/netlify/zip-it-and-ship-it/blob/9143e4e572963dc85c96e69c216160f9c77f045d/src/archive.js#L21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm i’ve been reading the adm-zip docs (that are v unclear lol) and i dont quite understand how i’d do this 😐 do yk exactly how this would be done with this package or should i switch to whatever zisi is doing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From checking their source code, it does not look like
adm-zip
allows setting themtime
.Based on this, I think copying the logic from
zip-it-and-ship-it
might be good. Eventually, I think we might want to fix this inzip-it-and-ship-it
sounstableNetlifyFunctionsSupport
should hopefully be removed in the future? (cc @eduardoboucas) If so, duplicating the logic might be ok IMHO.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes this will be removed in the future! :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this specific part can be a separate PR since it's a lower visibility issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm gonna defer the archiver/adm swap for if issues arise - as of right now there will be v few users using this and merging this is mainly to keep the temporary logic/branch up to date with main. want to unblock the cache PR and a lot of the other work i have to do and promised this to another user 😢 @eduardoboucas would you mind opening and/or sharing the issue to track the toml-side version of this work? 🙏 🙏