fix: dynamic imports with webpack 5 #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
possibly related but very unclear without more info from author: vercel/next.js#24739 |
lukeocodes
reviewed
May 12, 2021
lindsaylevine
force-pushed
the
ll/dynamic-imports-webpack-5
branch
from
105b99e to
ce4308a
Compare
jlengstorf
approved these changes
May 13, 2021
lindsaylevine
added a commit
that referenced
this pull request
May 14, 2021
This reverts commit ec62ee3.
lindsaylevine
added a commit
that referenced
this pull request
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #209
why, yes, this IS a tragic hack..
now a serverless function generated for a page (that requires it) will look like:
previously it was:
nextPage/index.jsnow it is:
nextPage/nextPage/index.jsto accommodate looking for chunks two levels up in webpack 5this is still backwards compatible with webpack 4, but unfortunately with next installed @ ^10.2.0 now in our project, we only test the webpack 5 behavior (< 10.2.0 was still default webpack 4).
i spent a good deal of time exploring the next source and webpack source to see if there was anything we could possibly do upstream to avoid this work. there's really nothing; it's just a breaking change in a major webpack update. everything runs fine on vercel, and i somehow couldn't identify any changes in the next source made to accommodate dynamic imports with webpack 5 - it appears they just work with the same source for wp4 and wp5? not sure.