feat: monorepo handling #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascorbic
added
monorepo
type: feature
| ) | ||
| } | ||
|
|
||
| const expectedConfigFile = path.resolve(netlifyConfig.build.publish, '..', 'next.config.js') |
|
|
||
| if (isNx) { | ||
| checkNxConfig({ netlifyConfig, packageJson, nextConfig, failBuild, constants }) | ||
| } |
Co-authored-by: lindsaylevine <[email protected]>
ascorbic
force-pushed
the
monorepo-weirdness
branch
from
3ba9d65 to
bdd9bee
Compare
lindsaylevine
approved these changes
Jun 25, 2021
| paths.unshift(nextRoot) | ||
| // ...then resolve the module using that list of paths. | ||
| return require.resolve(module, { paths }) | ||
| } |
| @@ -32,19 +37,24 @@ const build = async (functionsPath, publishPath) => { | |||
|
|
|||
| setupHeaders(publishPath) | |||
|
|
|||
| // ...and move back after | |||
| @@ -1,9 +1,8 @@ | |||
| const { PHASE_PRODUCTION_BUILD } = require('next/constants') | |||
There was a problem hiding this comment.
didnt want resolveNextModule here?
There was a problem hiding this comment.
Nah. For a test fixture it was going to be a big pain to pass-through all the config stuff
| command="npm run dev:demo" | ||
|
|
||
| [[plugins]] | ||
| package="." |
| netlify.toml | ||
| package.json | ||
| ``` | ||
| If you have another monorepo tool that you are using, we would welcome PRs to add instructions to this document. |
|
Awesome, thanks heaps for this. Really appreciate it and the updated docs. I may give lerna another shot when I work on my side-project again and let you know how I go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for monorepos to the plugin. Currently we only support building from subdirectories if they can be set as the base directory, and all packages can be installed from that root. This adds support for building sites in subdirectories, where the base is kept as the root. This means we can support most types of monorepo, including yarn workspaces and lerna. This PR also adds special handling for Nx sites, which do lots of strange magic with Next.js sites. We detect them specifically and check that the site is configured correctly.
For more details, see the included docs.
There are a number of places where I would like to add links to these docs. I will create a ntl.fyi shortlink once these are published, and then do a new PR to add the links to the error messages.
More info: #433. This is option 4.